Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features For Faster #129

Merged
merged 6 commits into from
Jul 27, 2023
Merged

Features For Faster #129

merged 6 commits into from
Jul 27, 2023

Conversation

jupster
Copy link
Collaborator

@jupster jupster commented Jul 27, 2023

This is still a WIP but it will allow people to have access to:

LogObjectNotFound = true;        //
SkipDescriptionParsing = false;   // Bi default Values 
ignoreMissionLoadErrors = false;  //
roleTimeOut = 90;       //
votingTimeOut = 60;     //
briefingTimeOut = 60;   // BI values by default
debriefingTimeOut = 45; //
armaUnitsTimeout = 30;  //

Description:

You will be able to change the time the same way currently lobby time out is set. I will all go into Server Advanced. I can put it in it's whole own section but it felt like it seemed right their.

Motivation and Context

##91
##124

How Has This Been Tested?

Still to be tested

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

@jupster jupster marked this pull request as ready for review July 27, 2023 08:57
@Foxlider
Copy link
Owner

I should have specified : Pull Requests should not be pushed on the master branch but the latest feature branch (feature/Update-1.9)

@Foxlider
Copy link
Owner

Bear with me but I'll try to edit it manually (although it might fuck things up, in this case my bad)

@Foxlider Foxlider changed the base branch from master to feature/Update-1.9 July 27, 2023 10:23
Added `armaUnitTimeout`
Set `LogObjectNotFound` default to true.
Cleaned up the UI by puting the boxes all together.
@Foxlider Foxlider merged commit 5a7e084 into Foxlider:feature/Update-1.9 Jul 27, 2023
@jupster jupster changed the title WIP - Features For Faster Features For Faster Jul 29, 2023
@jupster
Copy link
Collaborator Author

jupster commented Jul 29, 2023

It may be better/ easier to understand logObjectNotFound if it got switched around so when it is ticked by FASTER it is true.

Could make it that plus have faster have it ticked by default meaning it would still be set to BI default values.

@Foxlider Foxlider added the enhancement New feature or request label Sep 10, 2023
@Foxlider Foxlider assigned Foxlider and unassigned Foxlider Sep 10, 2023
@jupster jupster mentioned this pull request Sep 14, 2023
@jupster jupster added this to the 1.9 milestone Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants