Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds style for children edition table and menu overlay #1537

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Adds style for children edition table and menu overlay #1537

merged 2 commits into from
Nov 3, 2023

Conversation

Iloveall
Copy link
Collaborator

Description

Fixes #1528

Notes (out of scope, known isues, hints for reviewing code, ...) (optional)

...

Test cases

  • Case 1:
    1. Given I am the usual user
    2. When I go to this page
    3. Then I see new design for editable table
    4. Then I click on access icon
    5. Then I see new overlay menu with new icons
    6. And I hove on menu item
    7. Then I see hover style

@Iloveall Iloveall marked this pull request as draft October 27, 2023 15:20
@Iloveall Iloveall marked this pull request as ready for review October 27, 2023 15:25
@Iloveall Iloveall requested a review from smadbe October 27, 2023 15:25
smadbe
smadbe requested changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@smadbe smadbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(maybe not directly related with this one) Could you fix the alignement?
Screenshot 2023-10-30 at 11 06 07

@smadbe
Copy link
Contributor

smadbe commented Oct 30, 2023

The rest looks good 👍 🙂

@Iloveall Iloveall requested a review from smadbe October 30, 2023 16:28
@Iloveall Iloveall merged commit 27a0094 into master Nov 3, 2023
7 checks passed
@Iloveall Iloveall deleted the feature/fix-style-children-edition branch November 3, 2023 13:53
@Iloveall Iloveall mentioned this pull request Feb 22, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smadbe smadbe smadbe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix style of children edition
2 participants
@Iloveall @smadbe