Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve pykorm #11

Closed
wants to merge 3 commits into from
Closed

Improve pykorm #11

wants to merge 3 commits into from

Conversation

AnyISalIn
Copy link
Contributor

@AnyISalIn AnyISalIn commented Oct 17, 2020

Hi, Frank.

I found this project on GitHub two months ago. It is excellent and helped me build a PaaS project based on Kubernetes

In the process of using it, I also modified some codes to support the following functions

  • List field nesting & dictionary field nesting

  • Multi-cluster support

  • Label Filter & Field Selector Filter

  • editable & required and other verification

  • Kubernetes native API support

Here are some usage examples, https://github.com/AnyISalIn/pykorm/tree/master/examples

It works well in my project, Can you see what features can be merged into the master branch?

@Frankkkkk
Copy link
Owner

Hi @AnyISalIn !
Thanks for this huge MR !

I'll take a look into it this week and I'll keep you up to date.

Cheers and thanks !
Frank

@AnyISalIn
Copy link
Contributor Author

There may be some differences. I replaced the original dot with the @ symbol because, in some annotation scenarios, it seems to encounter some problem,I hope this PR can provide you with some help,Not necessarily need to merge

@Frankkkkk
Copy link
Owner

I had some time to work on it today. I've included your changes in MR #13 . It's still not finished but it should turn out fine :-).

PS: For now I haven't added the NestedFields and I've corrected a small bug when calling query.filter_by in different calls (https://github.com/Frankkkkk/pykorm/pull/13/files#diff-09fe136d8dc08ef90288da205e925789b0594f2c4286b664c73b3bca8299b8fcR24)

I'll keep you up to date,

Cheers

Frankkkkk pushed a commit that referenced this pull request Oct 22, 2020
This commit was initially written by AnyISalIn in a MR:
#11.
It has been refactored and simplified a bit by myself
(frank.villaro@infomaniak.com), keeping the original author.

Signed-off-by: Frank Villaro-Dixon <frank.villaro@infomaniak.com>
@Frankkkkk Frankkkkk mentioned this pull request Oct 22, 2020
@Frankkkkk
Copy link
Owner

Hi,
I'm closing the MR as it has been replaced by #14 and #17
Have a nice week,
Frank

@Frankkkkk Frankkkkk closed this Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants