Make dummy creation for calls consistent #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… dummy behavior
…known RecordDeclarations, fix tests to adapt to this behavior
Masrepus
added
the
graph-changing
oxisto
reviewed
Aug 25, 2020
| @@ -66,4 +62,13 @@ public static ConstructorDeclaration from(MethodDeclaration methodDeclaration) { | |||
|
|
|||
| return c; | |||
| } | |||
|
|
|||
| @Override | |||
| public void setRecordDeclaration(@Nullable RecordDeclaration recordDeclaration) { | |||
There was a problem hiding this comment.
Is that method actually called? Somehow does not look like it? Shouldn't it be called where you cut the original code?
There was a problem hiding this comment.
Yes it is called, e.g. in NodeBuilder.newConstructorDeclaration. What do you mean by "where you cut the original code"?
There was a problem hiding this comment.
Ah, i didn't see that it was overriding another function. I was refereeing to the lines 50-54 in the original code where you cut the code from and pasted in this new function. Looks ok then
|
I will ask @fwendland to do a quick check if this breaks anything in codyze, then we can merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, calls to unknown methods led to creation of dummy methods/functions in some situations, but not in all. This closes #135, as we now
Of course, we can't be 100% sure when analyzing this statically, e.g. as there could be methods that are declared in header files that we don't know. In this case, the call looks like a call to a local function or method of the current class, depending on its location. But in my opinion this is just something one has to live with when wanting to analyze even incomplete code to some degree.
Graph Changes
Calls to unknown functions/methods leads to creation of empty function/method declarations whose name, return type and signature matches the corresponding call expression. No new record declarations or translation units are created.