Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build for armv7-unknown-linux-musleabihf (RPi), bump version #1

Merged
merged 1 commit into from
Mar 20, 2022

Conversation

MightyPork
Copy link
Contributor

Fixes this error:

   Compiling faccess v0.2.3
error[E0308]: mismatched types
  --> /home/flowbox/.cargo/registry/src/github.com-1ecc6299db9ec823/faccess-0.2.3/src/lib.rs:95:36
   |
95 |             if faccessat(AT_FDCWD, path.as_ptr() as *const i8, mode, AT_EACCESS) == 0 {
   |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^ expected `u8`, found `i8`
   |
   = note: expected raw pointer `*const u8`
              found raw pointer `*const i8`

error: aborting due to previous error

For more information about this error, try `rustc --explain E0308`.
error: could not compile `faccess`.

To learn more, run the command again with --verbose.

@MightyPork
Copy link
Contributor Author

Reminding this old issue, we'd like to get rid of our patched fork. Could you please merge and publish it?

@Kezii
Copy link

Kezii commented Jul 4, 2021

I'd like to have this merged too

@r3dlight
Copy link

Hi, any chance to have this merged ?

@virtualritz
Copy link

virtualritz commented Dec 15, 2021

Bump!
This crate is b0rked on aarch64 too because of this.

@xenomorph1096
Copy link

Is there a possible work-around for this?

@MightyPork
Copy link
Contributor Author

@xenomorph1096 There is, copy the fixed version to your project and use a relative path, I've been doing that for 2 years :(

[patch.crates-io]
faccess = { path = "libs/faccess" }

@Freaky could you please merge this and publish?

@Freaky Freaky merged commit 1e7f954 into Freaky:master Mar 20, 2022
@Freaky
Copy link
Owner

Freaky commented Mar 20, 2022

0.2.4 published.

Sorry this took so long, I evidently forgot about it when I first saw it and then Github decided I didn't need notifying about new comments. WTF.

@xenomorph1096
Copy link

Hey thanks for merging! github works in mysterious ways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants