Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add React steps to README #64

Merged
merged 1 commit into from
Jul 25, 2019
Merged

Conversation

sdegutis
Copy link
Contributor

This should help get people motivated about using @pika/web and let them know that React support is possible, what its current state is, and how to get it working locally.

This excludes mention of Pika/CDN usages simply because this is @pika/web's readme.

This should help get people motivated about using @pika/web and let them know that React support is possible, what its current state is, and how to get it working locally.

This excludes mention of Pika/CDN usages simply because this is @pika/web's readme.
@thiagojedi
Copy link
Contributor

Nice. I didn't know nom had this kind of alias feature.

But I think this should be in Exemples.md (https://github.com/pikapkg/web/blob/master/EXAMPLES.md).

What do you think, @FredKSchott?

@FredKSchott
Copy link
Owner

+1, I agree that this is really just another example, but I think it brings up a good point that we could be highlighting these examples better (example: for someone doing a quick "Find" on the Readme). I'll merge this in to recognize the contribution (thanks for writing this up @sdegutis!) and then move things around a bit more.

@FredKSchott FredKSchott merged commit fe44a72 into FredKSchott:master Jul 25, 2019
@FredKSchott
Copy link
Owner

Alright, README and EXAMPLES edited and refreshed a bit. LMK what you think and feel free to point out or even PR any fixes.

@sdegutis if you can, I'd love a CodeSandbox or Glitch example of @esmreact to link to in the Examples page (right now I just have the steps without a working example to show).

@sdegutis sdegutis deleted the patch-1 branch July 26, 2019 14:38
@sdegutis
Copy link
Contributor Author

@FredKSchott Ok I'll look into it.

drwpow pushed a commit that referenced this pull request Jul 24, 2020
* added @snowpack/plugin-bundle-webpack

* File loader test pattern is now .*

* Excluded other patterns in file-loader, otherwise breaks

* Fix asset pattern

* Added extendConfig to plugin-bundle-webpack

* More config options for plugin-bundle-webpack.js

* Replaced optional chaining for earlier node versions

* Better error handling
drwpow pushed a commit that referenced this pull request Jul 27, 2020
* added @snowpack/plugin-bundle-webpack

* File loader test pattern is now .*

* Excluded other patterns in file-loader, otherwise breaks

* Fix asset pattern

* Added extendConfig to plugin-bundle-webpack

* More config options for plugin-bundle-webpack.js

* Replaced optional chaining for earlier node versions

* Better error handling
drwpow pushed a commit that referenced this pull request Jul 27, 2020
* added @snowpack/plugin-bundle-webpack

* File loader test pattern is now .*

* Excluded other patterns in file-loader, otherwise breaks

* Fix asset pattern

* Added extendConfig to plugin-bundle-webpack

* More config options for plugin-bundle-webpack.js

* Replaced optional chaining for earlier node versions

* Better error handling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants