Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plugin loading in electron #1375

Merged
merged 2 commits into from
May 18, 2020

Conversation

campersau
Copy link
Collaborator

@campersau campersau commented May 18, 2020

I made a mistake in #1350 which prevented ungit from beeing loaded in electron. I assumend that fs.readdir(..., { withFileTypes: true }) would just work in electron but since we are using asar it apparently does not. See electron/electron#19074

First commit refactors the code to the fs.readdir and fs.stat equivalent.
The second commit gets rid of the directory check completely because we already catch and ignore all errors 😄

@campersau campersau merged commit 6ab6caf into FredrikNoren:master May 18, 2020
@campersau campersau deleted the fixpluginloading branch May 18, 2020 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants