Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osx: add ssl_cert_file variable #34

Merged
merged 1 commit into from
Feb 8, 2020
Merged

Conversation

looooo
Copy link
Contributor

@looooo looooo commented Feb 8, 2020

@triplus I didn't push directly as I saw you are working on the appimage. Maybe you have some time to merge this one. I have tested it localy and it should fix the addon-manager problem on osx:
https://forum.freecadweb.org/viewtopic.php?f=3&t=42825

@triplus
Copy link
Contributor

triplus commented Feb 8, 2020

Done.

@triplus triplus closed this Feb 8, 2020
@triplus triplus reopened this Feb 8, 2020
@triplus triplus merged commit e21a74b into FreeCAD:master Feb 8, 2020
@looooo
Copy link
Contributor Author

looooo commented Feb 8, 2020

thx

@probonopd
Copy link
Collaborator

Interesting. This might potentially be useful for other AppImages as well. Why did you use SSL_CERT_FILE rather than SSL_CERT_DIR?

@triplus
Copy link
Contributor

triplus commented Feb 8, 2020

It is actually used in the AppImage already:

https://github.com/FreeCAD/FreeCAD-AppImage/blob/master/conda/linux_dev/AppDir/AppRun

Therefore i can confirm it is useful for AppImage purposes. At that time i tested different things and this is the one that work. I did a quick tests and it doesn't look like SSL_CERT_DIR is working. I tested on my local machine (extracted AppImage).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants