Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Client verification #620

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kleskjr
Copy link
Contributor

@kleskjr kleskjr commented Jun 7, 2018

verifing clients's public certificate and public key before establishing a secure connection

@oroulet
Copy link
Member

oroulet commented Jun 13, 2018

I have no idea if check is correct but it looks simple and valid. For storing certificate I propose that you make a new class called CertificateStoreInMemory or similar with a few methods like add_certicate an check_certificate (cert) and set_checker. Then add a method to InternalServer called set_certicate_store.Thus people can make their own implementation later. The certificate validation itself should be done in InternalServer or wherever you think is best

@oroulet
Copy link
Member

oroulet commented Jun 13, 2018

Maybe make a CertificateStoreInterface too with all methods raising NotImplemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants