Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
EAP-pwd: fix side-channel leak where 1 in 2018 handshakes fail
Previously the Hunting and Pecking algorithm of EAP-pwd aborted when more than 10 iterations are needed. Every iteration has a 50% chance of finding the password element. This means one in every 2048 handshakes will fail, in which case an error frame is sent to the client. This event leaks information that can be abused in an offline password brute-force attack. More precisely, the adversary learns that all 10 iterations failed for the given random EAP-pwd token. Using the same techniques as in the Dragonblood attack, this can be used to brute-force the password. This patch fixes the above issue by executing enough iterations such that the password element is always found eventually. Note that timing and cache leaks remain a risk against the current implementation of EAP-pwd.
- Loading branch information
3ea2a5a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why 100?