-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shadow gfx fix #9818
Shadow gfx fix #9818
Conversation
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
4d97fe3
to
83b370c
Compare
we need to wait until the capability messages are exchanged before starting to issue gfx commands
83b370c
to
d2f9809
Compare
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The [server,shadow] wait for rdpegfx channel ready
commit looks fine. Only did a very brief look upon the wlog changes, but I think these are okay. Not a fan of the last commit though
e51f77f
to
eb4391f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two nits
Refer to this link for build results (access rights to CI server needed): |
eb4391f
to
9b2a172
Compare
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
check if the message is allowed in current channel state.
If no image scaling is available disable capabilities that require image scaling to function properly
9b2a172
to
9f31aa4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Refer to this link for build results (access rights to CI server needed): |
delay gfx messages until the capability exchange is complete.