Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shadow gfx fix #9818

Merged
merged 4 commits into from
Jan 29, 2024
Merged

Shadow gfx fix #9818

merged 4 commits into from
Jan 29, 2024

Conversation

akallabeth
Copy link
Member

@akallabeth akallabeth commented Jan 29, 2024 •
edited

delay gfx messages until the capability exchange is complete.

@akallabeth akallabeth linked an issue Jan 29, 2024 that may be closed by this pull request
freerdp-shadow-cli: issues with GFX channel and MSTSC #9660
Closed
@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11291/

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11292/

@akallabeth akallabeth added this to the next-3.0 milestone Jan 29, 2024
@akallabeth
[server,shadow] wait for rdpegfx channel ready
9085150 
we need to wait until the capability messages are exchanged before
starting to issue gfx commands
@akallabeth
[channel,rdpgfx] use dynamic WLog for server channel
725c99b
@akallabeth akallabeth marked this pull request as ready for review January 29, 2024 14:10
@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11293/

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11294/

pnowack
pnowack reviewed Jan 29, 2024
View reviewed changes
Copy link
Member

@pnowack pnowack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The [server,shadow] wait for rdpegfx channel ready commit looks fine. Only did a very brief look upon the wlog changes, but I think these are okay. Not a fan of the last commit though

channels/rdpgfx/server/rdpgfx_main.c Outdated Show resolved Hide resolved
@akallabeth akallabeth force-pushed the shadow_gfx_fix branch 2 times, most recently from e51f77f to eb4391f Compare January 29, 2024 16:36
pnowack
pnowack reviewed Jan 29, 2024
View reviewed changes
Copy link
Member

@pnowack pnowack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two nits

channels/rdpgfx/client/rdpgfx_main.c Outdated Show resolved Hide resolved
channels/rdpgfx/client/rdpgfx_main.c Outdated Show resolved Hide resolved
@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11300/

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11301/

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11302/

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11303/

@akallabeth
[channels,rdpgfx] add server side channel checks
f6c110b 
check if the message is allowed in current channel state.
@akallabeth
[channel,rdpgfx] disable client side caps
9f31aa4 
If no image scaling is available disable capabilities that require image
scaling to function properly
pnowack
pnowack approved these changes Jan 29, 2024
View reviewed changes
Copy link
Member

@pnowack pnowack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11304/

@pnowack pnowack merged commit 5cb463e into FreeRDP:master Jan 29, 2024
3 checks passed
@akallabeth akallabeth deleted the shadow_gfx_fix branch January 29, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pnowack pnowack pnowack approved these changes

@bmiklautz bmiklautz Awaiting requested review from bmiklautz

@mfleisz mfleisz Awaiting requested review from mfleisz

@hardening hardening Awaiting requested review from hardening

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.

freerdp-shadow-cli: issues with GFX channel and MSTSC
3 participants
@akallabeth @freerdp-bot @pnowack