Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis: build flatpak using branch from PR instead of next #1611

Merged
merged 3 commits into from
May 10, 2018
Merged

travis: build flatpak using branch from PR instead of next #1611

merged 3 commits into from
May 10, 2018

Conversation

larchunix
Copy link
Contributor

Currently, travis flatpak build always uses the tip of next branch. This means builds triggered by a pull request does not test the changes introduced by the PR since the code is not merged in next branch yet.

This PR aims to fix this.

@larchunix larchunix merged commit 1a9da55 into FreeRDP:next May 10, 2018
@antenore
Copy link
Member

Thanks @larchunix
The only issue is that the build takes around 20 minutes.

Sometimes it's just awful to wait, that's why we decided to build only next.

Well, I prefer to wait and be sure everything works.

@amtlib-dot-dll
Copy link
Contributor

Thanks @larchunix
@antenore Probably we can utilize the cache and build stages features of Travis?

@larchunix larchunix deleted the travis-flatpak branch May 10, 2018 16:08
@antenore
Copy link
Member

@amtlib-dot-dll I forgot to answer to you, sorry.

Well, yes! Do you know ho to do it? Otherwise I'll take a look when I'll be back from vacation and as soon as possible (i'm quite busy with my duties ;-) )

@amtlib-dot-dll
Copy link
Contributor

Well me too, but as users are developers for free softwares, we are not alone, are we? 😉

@antenore
Copy link
Member

I've enabled the travis cache trough #1619
We will see if it works with the next PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants