Create manifest.yml #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitwallit
reviewed
Oct 8, 2020
manifest.yml
Outdated
| name : "FreeRTOS-Plus-TCP" | ||
| version: "V2.3.0" | ||
| description: |- | ||
| "FreeRTOS TCP/IP stack working on top of FreeRTOS-Kernel to implement IP protocol. Suitable for microcontrollers." |
There was a problem hiding this comment.
- small grammar - "the" FreeRTOS-Kernel (2) does it not also implement the TCP protocol?
There was a problem hiding this comment.
Thanks for your review.
- I corrected the grammatical mistake. Thanks.
- It has been called TCP/IP stack in all our documentation (and technically TCP or IP cannot work without one another). Thus, I modified the statement to call it "TCP/IP" instead of "IP" stack.
gitwallit
approved these changes
Oct 8, 2020
cobusve
approved these changes
Oct 8, 2020
gkwicker
approved these changes
Oct 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
manifest.ymlfile to the TCP repository.Test Steps
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.