Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor change in labeling player buttons #1682

Closed
efb4f5ff-1298-471a-8973-3d47447115dc opened this issue Sep 9, 2021 · 0 comments · Fixed by #4978
Closed

Minor change in labeling player buttons #1682

efb4f5ff-1298-471a-8973-3d47447115dc opened this issue Sep 9, 2021 · 0 comments · Fixed by #4978
Labels
enhancement New feature or request player-related Player-related changes are currently on hold due to the ongoing player migration.

Comments

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

efb4f5ff-1298-471a-8973-3d47447115dc commented Sep 9, 2021

Is your feature request related to a usage problem (not a bug)? Please describe.
There is at the moment no consistent labeling between the player icons.
A few icons have the word toggle in them others have not.
When u enable the feature that presents the icon and u hover over it will still say toggle instead of untoggle or something like that.

Describe the solution you'd like to see implemented
I would change the labeling of these icons.

  • Playback rate > Playback speed (this one is not necessary but it would make it the same as YT)
  • Toggle loop > Loop
  • (When loop is enabled and u want to disable it, the label should say) Toggle loop > Exit loop
  • Toggle theatre mode > Theatre mode
  • (When theatre is enabled and u want to disable it, the label should say) Toggle theatre mode > Default view
  • (When Full Window is enabled and u want to disable it, the label should say) Full Window > Default view or Exit Full Window
  • Select quality > Quality

This also makes it a bit more consistent with the name convention YouTube uses.

Describe alternatives you've considered
None.

Screenshots
None.

Additional context
None.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request player-related Player-related changes are currently on hold due to the ongoing player migration.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants