Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: "Autoplay Playlists" setting in internal player does not work as expected (or at all) #5095

Closed
6 tasks done
Quikswitch opened this issue May 10, 2024 · 5 comments
Closed
6 tasks done

Comments

@Quikswitch
Copy link

Quikswitch commented May 10, 2024

Guidelines

  • I have encountered this bug in the latest release of FreeTube.
  • I have encountered this bug in the official downloads of FreeTube.
  • I have searched the issue tracker for open and closed issues that are similar to the bug report I want to file, without success.
  • I have searched the documentation for information that matches the description of the bug I want to file, without success.
  • This issue contains only one bug.

Describe the bug

  1. Enable settings as shown on the picture (Autoplay playlists on; autoplay videos off)
  2. Open video outside of playlist to confirm "Autoplay Videos" being disabled works as intended
  3. Open a playlist
  4. Observe that the first video in the playlist doesn't autoplay (intended? it's alright as is imo)
  5. Let video playthrough (or skip to the end)
  6. BUG: Player switches to the next video automatically, but does not autoplay the next video in the playlist

Expected Behavior

The reason why I consider this to be a bug is that "autoplay playlists" as implemented is not a useful feature on its own. There's no point in making playlists go to the next video automatically if it needs to be started manually. "Autoplay videos", when enabled, produces correct behavior, but that setting also affects videos outside playlists, which a user may want to not autoplay.

User story: I like to open several videos on my subscription feed when I get on the computer for the day. I do not want them to autoplay, as I simply want to have a "to watch" list for the selected videos, and I can't watch more than one at once. After finishing those videos, and closing those windows, I want to listen to music through a playlist. The playlist, however, does not autoplay videos as expected unless I tweak settings in between these activities. This is an issue.

Expected behavior:
Videos in playlists will switch automatically, as they currently do, and autoplay, as they currently do not, when "Autoplay Playlists" is enabled, regardless of the state of the setting "Autoplay Videos"

Issue Labels

inconsistent behavior, usability issue

FreeTube Version

v0.20.0 Beta

Operating System Version

Windows 10 Home, v19045.4291

Installation Method

.exe

Primary API used

Local API

Last Known Working FreeTube Version (If Any)

Unknown

Additional Information

example settings

Nightly Build

@kommunarr
Copy link
Collaborator

I think your confusion comes down to our naming system being odd. "Autoplay Videos" means "start video automatically without clicking play button". "Autoplay Playlists" means "play next video in list automatically," with the generic version (e.g., for upcoming Recommended Videos) being "Play Next Video". Does this address your concern?

@jn64
Copy link

jn64 commented May 11, 2024

I understand the naming and the current (intended) behaviour, but I agree with the reporter that the current behaviour is not useful.

I want single videos to not autoplay, but playlists to autoplay (meaning go to the next video and start playing it). There is no way to get this since Autoplay Videos affects both. I have to change the setting every time I want to watch a playlist.

Not a bug so much as a missing feature.

@kommunarr
Copy link
Collaborator

kommunarr commented May 11, 2024

I think I understand now, although that ask is admittedly a bit niche. Maybe that use case would be best served by having a profile with that setting enabled (once we have this behavior in implemented in #1996), then you can have any types of videos you choose to watch on that profile start automatically.

@jn64
Copy link

jn64 commented May 11, 2024

At the very least, two settings shouldn't be named "autoplay" when they mean different things.

My suggestion / feature request would be:

  1. Split Autoplay Videos into 2 new settings:

    • Autoplay videos (applies to videos not in playlists)
    • Autoplay videos in playlists
  2. Rename Autoplay Playlists to Load next video in playlist automatically

  3. Rename Play next video to Load next recommended video automatically (I don't know if this is used for anything other than recommended videos)

I use "autoplay" to mean "automatically start playing the video on load". I don't know if this is the commonly accepted meaning, or if my suggestions should be flipped around so that (2) and (3) use "autoplay" and (1) is called something else.

@kommunarr
Copy link
Collaborator

I use "autoplay" to mean "automatically start playing the video on load". I don't know if this is the commonly accepted meaning, or if my suggestions should be flipped around so that (2) and (3) use "autoplay" and (1) is called something else.

There's a PR looking for a new author to take over that implements this naming change in the template and variable naming: #4342. Reason for doing so is that "Autoplay" in the "play next" meaning has been made more common by platforms like YT than the other interpretation. "Split Autoplay Videos" is the only step that we do not plan to implement at this time, as its use case should be adequately addressed by the other solution I shared.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants