Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Channel Member Icons + Load Custom Channel Emojis in Comments #1819

Merged
merged 6 commits into from
May 14, 2022
Merged

Feat: Channel Member Icons + Load Custom Channel Emojis in Comments #1819

merged 6 commits into from
May 14, 2022

Conversation

ChunkyProgrammer
Copy link
Member

@ChunkyProgrammer ChunkyProgrammer commented Oct 14, 2021 •
edited
Loading

Feat: Channel Member Icons + Load Custom Channel Emojis in Comments

Pull Request Type
Please select what type of pull request this is:

  • Bugfix
  • Feature Implementation

Related issue
None

Description
This PR will show a visual indicator for channel members & load custom channel emojis

Screenshots (if appropriate)
Please add before and after screenshots if there is a visible change.

Channel member icon:
image

Custom channel emoji:
image

Testing (for code that is not small enough to be easily understandable)
Has this pull request been tested?
Yes, I found comments that were by members or contained custom emojis and they loaded. I also tested to make sure that these changes wouldn't break invidious.

Desktop (please complete the following information):

  • OS: Windows
  • OS Version: 10
  • FreeTube version: latest nightly

Additional context
This PR requires FreeTubeApp/yt-comment-scraper#32 to be merged & a new version of yt-comment-scraper to be released in order to work

Open
5 tasks
@ChunkyProgrammer ChunkyProgrammer marked this pull request as ready for review February 9, 2022 20:02
@ChunkyProgrammer ChunkyProgrammer added PR: waiting for review For PRs that are complete, tested, and ready for review and removed PR: WIP labels Feb 9, 2022
@PrestonN PrestonN enabled auto-merge (squash) February 9, 2022 20:04
@ChunkyProgrammer
Copy link
Member Author

For testing, I found this vid to be pretty good. https://youtu.be/3fQSmvT7LOU Pinned comment has a channel icon in it. And there's a channel that is a member that should load on the first page

@PikachuEXE
Copy link
Collaborator

Custom channel emoji tested but can't find any channel member
image
image

@ChunkyProgrammer
Copy link
Member Author

Custom channel emoji tested but can't find any channel member image image

Pinato is the channel member

PikachuEXE
PikachuEXE approved these changes Feb 10, 2022
View reviewed changes
Copy link
Collaborator

@PikachuEXE PikachuEXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK then Channel member icon works too
I thought that's part of his username

@PikachuEXE
Copy link
Collaborator

Not enough reviewers oops!

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

efb4f5ff-1298-471a-8973-3d47447115dc commented Feb 21, 2022 •
edited
Loading

Its working for me but i dont know why but i see allot of missing profiles pictures.
The pictures are not missing in the latest nightly build.

Capture

@PikachuEXE
Copy link
Collaborator

@efb4f5ff-1298-471a-8973-3d47447115dc
I am unable to reproduce but this can be setting related issue
Maybe try to inspect the thumbnail URLs?
Here's mine

image

efb4f5ff-1298-471a-8973-3d47447115dc
efb4f5ff-1298-471a-8973-3d47447115dc approved these changes Mar 2, 2022
View reviewed changes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, i had update my dependencies and all the weird issues i got were resolved. Ty for helping out!

@PikachuEXE
Copy link
Collaborator

Where should we find the third reviewer?

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

efb4f5ff-1298-471a-8973-3d47447115dc commented Mar 3, 2022 •
edited
Loading

Maybe @PrestonN could be the third reviewer?

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added PR: merge conflicts / rebase needed and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Apr 9, 2022
@ChunkyProgrammer ChunkyProgrammer added PR: waiting for review For PRs that are complete, tested, and ready for review and removed PR: merge conflicts / rebase needed labels May 13, 2022
PrestonN
PrestonN approved these changes May 14, 2022
View reviewed changes
Copy link
Member

@PrestonN PrestonN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PrestonN PrestonN merged commit 62bdf5e into FreeTubeApp:development May 14, 2022
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label May 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc approved these changes

@PrestonN PrestonN PrestonN approved these changes

@PikachuEXE PikachuEXE PikachuEXE approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ChunkyProgrammer @PikachuEXE @efb4f5ff-1298-471a-8973-3d47447115dc @PrestonN