Allow DASH formats for livestream replays #2208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efb4f5ff-1298-471a-8973-3d47447115dc
added
the
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Apr 20, 2022
PikachuEXE
approved these changes
Apr 24, 2022
github-actions
bot
removed
the
PR: waiting for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow DASH formats for livestream replays
Pull Request Type
Description
Currently FreeTube enforces the legacy formats for all livestreams regardless of whether they are live or replays. This pull requests allows DASH formats to be used for livestream replays.
Screenshots (if appropriate)
Before:
After:
Testing (for code that is not small enough to be easily understandable)
I tested various videos to check that nothing broke. Here is an example of a livestream replay video that has DASH formats after this change: https://youtu.be/TEygSwHWhfA
Desktop (please complete the following information):