Fix: csv import/export #2247
Merged
Fix: csv import/export #2247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChunkyProgrammer
added
the
PR: waiting for review
Closed
3 tasks
|
I could import the .csv but did get a bunch of these errors #2248 So im just providing the log to be sure |
That issue should be fixed by FreeTubeApp/yt-channel-info#78 |
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
May 23, 2022
efb4f5ff-1298-471a-8973-3d47447115dc
requested review from
PikachuEXE and
absidue
PikachuEXE
approved these changes
May 24, 2022
absidue
approved these changes
May 25, 2022
github-actions
bot
removed
the
PR: waiting for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: csv import/export
Pull Request Type
Please select what type of pull request this is:
Related issue
closes #2219
Description
Removes blank lines from csv files when importing, adds quotation marks to channel names that have commas in them for exporting
Testing (for code that is not small enough to be easily understandable)
Has this pull request been tested?
I imported and exported the csv file provided in the issue and the import and export worked
Desktop (please complete the following information):