Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Most Popular if invidious is disabled #2772

Merged

Conversation

ChunkyProgrammer
Copy link
Member

@ChunkyProgrammer ChunkyProgrammer commented Oct 26, 2022

Hide Most Popular if invidious is disabled

Pull Request Type

  • Bugfix

Description

Hide Most Popular if invidious is disabled (not primary api/fallback)

Testing

API Fallback Most Popular Visible?
Local false Hidden
Local true Visible
Invidious false Visible
Invidious true Visible

Desktop

  • OS: Windows
  • OS Version: 11
  • FreeTube version: 0.17.1

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Oct 26, 2022
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) October 26, 2022 14:43
Copy link
Collaborator

@PikachuEXE PikachuEXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally

@FreeTubeBot FreeTubeBot merged commit f46132c into FreeTubeApp:development Oct 27, 2022
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Oct 27, 2022
@ChunkyProgrammer ChunkyProgrammer deleted the hide-most-popular branch October 27, 2022 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants