Reset current chapter index when changing videos #3400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc and
ChunkyProgrammer
github-actions
bot
added
the
PR: waiting for review
ChunkyProgrammer
approved these changes
Apr 4, 2023
PikachuEXE
approved these changes
Apr 5, 2023
|
@efb4f5ff-1298-471a-8973-3d47447115dc Please review this when you have time :). |
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Apr 8, 2023
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Apr 17, 2023
* development: Add 50fps and live support to frame by frame keyboard shortcuts (FreeTubeApp#3420) Remove invidious.namazso.eu in dev branch (FreeTubeApp#3425) Cleanup polyfills (FreeTubeApp#3383) Small community post fixes (FreeTubeApp#3401) Bump rimraf from 4.4.1 to 5.0.0 (FreeTubeApp#3409) Bump peter-evans/create-pull-request from 4 to 5 (FreeTubeApp#3414) Bump eslint from 8.37.0 to 8.38.0 (FreeTubeApp#3416) Bump lefthook from 1.3.8 to 1.3.9 (FreeTubeApp#3410) Bump webpack from 5.77.0 to 5.78.0 (FreeTubeApp#3411) Bump youtubei.js from 4.1.1 to 4.2.0 (FreeTubeApp#3412) Bump sass from 1.60.0 to 1.61.0 (FreeTubeApp#3413) Update Channel age restricted key (FreeTubeApp#3237) Fix some translation entries sometimes not used when rendered (FreeTubeApp#3337) Reset current chapter index when changing videos (FreeTubeApp#3400)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reset current chapter index when changing videos
Pull Request Type
Related issue
closes #3386
Description
Currently the property on the watch page tracking the current chapter doesn't get reset when you switch to a new video. That can cause issues in some cases like in the issue linked above, causing the chapters component to break and spam the console with errors. This could probably also be fixed some other way by adjusting the chapters logic but resetting the property is a much easier fix.
Testing
Desktop