Chores: move 'blur' to be thumbnailPreference, move 1 dep to devDependencies #4218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
PR: dependencies
kommunarr
requested review from
PikachuEXE,
absidue,
efb4f5ff-1298-471a-8973-3d47447115dc and
ChunkyProgrammer
PikachuEXE
previously approved these changes
Oct 24, 2023
absidue
reviewed
Oct 27, 2023
absidue
approved these changes
Oct 27, 2023
PikachuEXE
approved these changes
Oct 28, 2023
ChunkyProgrammer
approved these changes
Oct 31, 2023
github-actions
bot
removed
the
PR: waiting for review
ab-shrek
pushed a commit
to ab-shrek/FreeTube
that referenced
this pull request
Nov 2, 2023
…dencies (FreeTubeApp#4218) * Chore: move stylelint-use-logical-spec to devDependencies * Update blur to be a thumbnail preference instead of its own ft-toggle-switch * Update en-US.yaml
kommunarr
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Nov 18, 2023
…dencies (FreeTubeApp#4218) * Chore: move stylelint-use-logical-spec to devDependencies * Update blur to be a thumbnail preference instead of its own ft-toggle-switch * Update en-US.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chores: move 'blur' to be thumbnailPreference, move 1 dep to devDependencies
Pull Request Type
Related issue
One chore from our backlog, and this comment
Description
devDependenciesblurto be a thumbnailPreference in a backward-compatible way so as to avoid inconveniencing users who already have this feature activeTesting
Blur Thumbnailsunder Distraction Free Settings to true, then open this PR and seeBluras selected value of Thumbnail Preference under General Settings & blur working normallyBlurDesktop
Additional context
Not sure if there is a better way to maintain reverse compatibility with combined settings; I couldn't find examples of us doing this before. Let me know if this is a good way of handling it.