Order watched recommended videos last

[kommunarr]

Order watched recommended videos last

Pull Request Type

• Feature Implementation

Related issue

closes #397

Description

Orders watched videos last in the recommended videos list. Only sets ordering once when route is first loaded, not live during any "Mark as Watched" / "Mark as Unwatched" events (because this would be undesirable). This should functionally make infinite autoplay loops impossible.

Testing

• Enable autoplay and mark videos at the top of the rec list as watched
• Reload route and see that those watched videos are at the bottom of the rec list
• Let video autoplay and see that the video visibly at the top of the rec list is played

Desktop

• OS: OpenSUSE Tumbleweed
• OS Version: 2023xxxx
• FreeTube version: 0.19.1

[efb4f5ff-1298-471a-8973-3d47447115dc]

not live during any "Mark as Watched" / "Mark as Unwatched" events (because this would be undesirable)

Why would this be undesirable? Wouldnt it be a good thing that i can mark something as watched and it will not autoplay as the next video?

[kommunarr]

I was more referring to the physical ordering aspect, which would be jarring to have it jump out of view if you marked it as watched. Detaching the visible display order of the videos from how they would be autoplayed seems unintuitive. I think there's an interesting use case for manipulating the autoplay order on the go, but that would fall in line with either a Queue feature (#547) and/or hiding videos (#1362).

[efb4f5ff-1298-471a-8973-3d47447115dc]

To me it feels a bit like unexpexted behavior when i mark the first video in the list as watched and still get it when the autoplay kicks in. I feeling could be wrong though.

[kommunarr]

To me it feels a bit like unexpexted behavior when i mark the first video in the list as watched and still get it when the autoplay kicks in

I think that would make sense if it was a labeled feature like "Keep watched videos last," but as it stands, I think reordering the recommended videos list based on Mark as Watched is more jarring & not in line with user expectations of how things would work. Open to hearing other perspectives on this though!

[PikachuEXE]

Right now I would say it's unnecessary to move entries marked as watched to the bottom
If they want to play non 1st item, just click on it

[efb4f5ff-1298-471a-8973-3d47447115dc]

@PikachuEXE just so we are one the same page, Im not talking about it moving visually just moving it behind the scenes so the user doesnt get to see that vid

[PikachuEXE]

So more like on video end
Pick 1st recommended not marked as watched video to autoplay? (fallback to 1st video if all watched)

[efb4f5ff-1298-471a-8973-3d47447115dc]

Yup exactly like that. If for some reason i see a video on top of the recommended videos list but i already seen it. The user marks it as watched. When its time for the autoplay to go to the next video it should skip that one on the top i just marked as watched and pick the 2nd one in line

[kommunarr]

I don't think that's intuitive behavior unless you're expecting that to happen & behave like that already, which most people wouldn't be. You would want & expect that behavior to happen for something like video-hiding or a watch queue. This current feature is more of a subtle convenience feature for regulating how we order recommended videos for preventing circular autoplay loops.

[efb4f5ff-1298-471a-8973-3d47447115dc]

Good point you made!

[absidue]

Could you please use a local/temporary variable and only assign the final value to this, instead of assigning and then overwriting the value in this? (should be slightly more efficient as it will only trigger the watcher once, although hopefully Vue is clever enough to detect those back to back changes and only update the watch-video-recommendations component once).