-
Notifications
You must be signed in to change notification settings - Fork 834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow searching FreeTube through the command line #4675
Closed
ChunkyProgrammer
wants to merge
13
commits into
FreeTubeApp:development
from
ChunkyProgrammer:add-command-line-arg-to-search
+25
−5
Closed
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
5e5e6d2
Add command line arg to search FreeTube
ChunkyProgrammer b46553a
Merge branch 'development' into add-command-line-arg-to-search
ChunkyProgrammer d9747bc
url encode search query
ChunkyProgrammer 40c1c01
Merge branch 'development' into add-command-line-arg-to-search
ChunkyProgrammer 39e6936
Merge branch 'development' into add-command-line-arg-to-search
ChunkyProgrammer 11973f9
Merge branch 'development' into add-command-line-arg-to-search
ChunkyProgrammer c6e05a5
Merge branch 'development' into add-command-line-arg-to-search
ChunkyProgrammer 5a71ff2
Merge branch 'development' into add-command-line-arg-to-search
ChunkyProgrammer 977ef1c
Merge branch 'development' into add-command-line-arg-to-search
ChunkyProgrammer 5dc9cb8
Merge branch 'development' into add-command-line-arg-to-search
ChunkyProgrammer 72187e7
Merge branch 'development' into add-command-line-arg-to-search
ChunkyProgrammer e133dc6
merge latest changes into branch
ChunkyProgrammer 55a508d
Merge branch 'development' into add-command-line-arg-to-search
ChunkyProgrammer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
const events = new EventTarget() | ||
export default events |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me start with saying I have no position in the FreeTube project, but there is one note from me.
If the interface of the
updateSearchInputText
function should be changed - it's now object instead of string - the function should probably be renamed to better signify the use case.Maybe a different question. Does the interface need to change at all? The underlying
this.$refs.searchInput.updateInputData
function expects string as well. Maybe for the use case as event handlers, theupdateSearchInputText
could be wrapped in a handler and called with thequery
the handler receives.Also in following file, the
updateSearchInputText
is still used in the unchanched way. https://github.com/ChunkyProgrammer/FreeTube/blob/5c6abd99e53ea7edc6c24c0a3b5dc3530cc6e7c5/src/renderer/App.js#L473