Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide channel sidebar label under more when Hide Side Bar Labels setting is enabled #4678

Conversation

MarmadileManteater
Copy link
Contributor

Hide channel sidebar label under more when Hide Side Bar Labels setting is enabled

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Description

The channel sidebar label under more does not hide when the hide sidebar labels setting is enabled. This PR addresses this by applying the same v-if to that channel label as all the other side bar labels.

Screenshots

before after
image image

Testing

  1. Enable the Hide Side Bar Labels setting
  2. Reduce the width of the window to around <=680px
  3. Ensure that the Channels side bar option under ... doesn't show the label

Desktop

  • OS: Windows 10
  • OS Version: Pro Version 21H2 Installed on ‎4/‎3/‎2022 OS build 19044.1889 Experience Windows Feature Experience Pack 120.2212.4180.0
  • FreeTube version: 28cc5ef

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Feb 14, 2024
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) February 14, 2024 16:18
@FreeTubeBot FreeTubeBot merged commit d335151 into FreeTubeApp:development Feb 15, 2024
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Feb 15, 2024
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this pull request Feb 15, 2024
…-user-playlist-2

* development: (66 commits)
  Translated using Weblate (Portuguese (Brazil))
  Translated using Weblate (Czech)
  Translated using Weblate (Hungarian)
  Translated using Weblate (Estonian)
  Translated using Weblate (Turkish)
  Translated using Weblate (Spanish)
  Translated using Weblate (Arabic)
  Translated using Weblate (Italian)
  Translated using Weblate (Polish)
  Translated using Weblate (French)
  Translated using Weblate (Chinese (Traditional))
  Translated using Weblate (Chinese (Simplified))
  Fix overflow issue with share playlist icon drop-down (FreeTubeApp#4677)
  Fix the Invidious DASH manifest generation (FreeTubeApp#4672)
  Hide channel sidebar label under `more` when setting is enabled (FreeTubeApp#4678)
  Translated using Weblate (Norwegian Nynorsk)
  Translated using Weblate (Serbian)
  Remove excessive punctuation as part of distraction settings (FreeTubeApp#4673)
  Bump the stylelint group with 1 update (FreeTubeApp#4669)
  Bump swiper from 11.0.5 to 11.0.6 (FreeTubeApp#4670)
  ...

# Conflicts:
#	src/renderer/components/playlist-info/playlist-info.scss
@MarmadileManteater MarmadileManteater deleted the hide-channel-label-with-setting-on-mobile branch March 16, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants