Add confirmation popup before unsubscribing

[msagr]

Added a popup to ask for confirmation before unsubscribing

Pull Request Type

• Bugfix
• Feature Implementation
• Documentation
• Other

Related issue

closes #4109

Description

It asks for a confirmation while unsubscribing channel, to avoid accidental unsubscription.

Screenshots

Testing

I tested it by first subscribing various channels, and everytime I unsubscribed a channel, it would ask me for a confirmation that if I really want to unsubscribe.

Desktop

• **OS:**Ubuntu
• **OS Version:**22.04
• **FreeTube version:**0.20.0

[efb4f5ff-1298-471a-8973-3d47447115dc]

I like the way you implemented it but im not sure if the issue has valid reasoning for this to exist. Now if you need to unsubscribe one channel from lets say 3 profiles you are encountering this 3 times. Do the same routine for 10 more channels and this will get very annoying very quickly.

If some of the other reviewers think this is a valid PR than there should be a toggle for this confirmation in the settings (maybe parental control idk)

[absidue]

If we do decide to keep this, then it should be changed to use the ft-prompt component so that it matches the popups throughout the rest of the app.

[PikachuEXE]

I think there should be a toggle for this

[msagr]

Yeah, I think that it makes more sense to have a separate option in setting like avoid accidental unsubscription which when enabled, then only the user will be shown popup while unsubscribing. Should I try to implement it this way?

[efb4f5ff-1298-471a-8973-3d47447115dc]

@msagr yes please implement the suggested changes :)

[msagr]

Screencast.from.13-04-24.01.48.16.PM.IST.webm

[efb4f5ff-1298-471a-8973-3d47447115dc]

Dropdown should not close after i removed the channel from a profile

VirtualBoxVM_7ZveIUYxNN.mp4

popup playing hide and seek on the player page

VirtualBoxVM_v5CRDh3dEI.mp4

[msagr]

Thanks @efb4f5ff-1298-471a-8973-3d47447115dc for the review, I will try to implement the suggested changes.

[msagr]

@efb4f5ff-1298-471a-8973-3d47447115dc, I was trying to move the side videopanel out of focus when the prompt pops up but i am facing difficulty in doing that. Can you please suggest me something?

[kommunarr]

popup playing hide and seek on the player page

I've tested merging this with #3975 and am no longer seeing this bug here. Do we want to wait on this PR until that one is merged?

[efb4f5ff-1298-471a-8973-3d47447115dc]

Key difference from you screenshot vs mine

Your player is in theatre mode and mine isnt. Did you test this with both modes?

[kommunarr]

Edit: sorry for the temporary laziness. Yes, it works with both modes:

[efb4f5ff-1298-471a-8973-3d47447115dc]

Approving after #3975 is merged

[kommunarr]

Needs to be rebased with development, and then it should be working as intended

[efb4f5ff-1298-471a-8973-3d47447115dc]

@jasonhenriquez should #4374 be merged first?

[kommunarr]

It's arguable, so maybe yes. It's the least destructive action we could have, and easily reversible at that, but should still probably be marked properly given the use case it's trying to solve for (accidental unsubscribing)

[efb4f5ff-1298-471a-8973-3d47447115dc]

Both PR's are merged. Rebase into development branch

[github-actions]

This PR is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 14 days.

[zipfile6209]

Unfortunately it looks like @msagr is busy, it would be a pity if his cool work was lost.

I don't know about programming but I gather that all the work is done and that bringing it to the current version could be very easy. Would it be impolite to ask if another dev could put the finishing touches on it?

[efb4f5ff-1298-471a-8973-3d47447115dc]

The devs are people with very limited time because we all do this in our spare time. If we had to take over every PR that gets abandoned we would never get to the important stuff.

We have way more important stuff todo with our limited time than addressing low priority issues like this one.

New contributors feel free to take the code of the PR and make the necessary changes

[PikachuEXE]

Tested after merging locally (before OP merged dev branch recently)