-
Notifications
You must be signed in to change notification settings - Fork 856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add icons to dropdowns #5006
Add icons to dropdowns #5006
Conversation
a8c2048
to
229a32a
Compare
Co-authored-by: PikachuEXE <git@pikachuexe.net>
BUG! How it looked like before FreeTube_YNgeZAxmJ0.mp4How it looks like now VirtualBoxVM_K8Oq5THgEJ.mp4 |
So icon needs to disappear when the control is disabled. Got it. I will probably bundle this fix into a related PR if that's okay, as this is pretty minor |
It also doesnt name the previous overwritten colors anymore. It just says primary and secondary color |
Sometimes the color pallete isnt updating the color under the Sponserblock settings FreeTube_hBsN3DnEAV.mp4 |
Ah, I see, it's passing in the color name and not the actual value. It's a cute accident that it's actually working with the built-in CSS color names. |
Add icons to dropdowns
Pull Request Type
Related issue
closes #5005
Description
ft-select
ft-select
s have anicon
prop specifiedicon-color
prop as well (used in SponsorBlock Settings and Theme Settings to allow user to see the selected color reflected on the icon itself)Screenshots
Testing
ft-selects
Desktop
Additional context