Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icons to dropdowns #5006

Merged

Conversation

kommunarr
Copy link
Collaborator

Add icons to dropdowns

Pull Request Type

  • Feature Implementation

Related issue

closes #5005

Description

  • Adds icon to every ft-select
  • Requires all ft-selects have an icon prop specified
    • This is a simple enough requirement that also notably greatly reduces the cognitive effort of scanning for sighted users.
  • Adds optional icon-color prop as well (used in SponsorBlock Settings and Theme Settings to allow user to see the selected color reflected on the icon itself)

Screenshots

Screenshot_20240423_130405
Screenshot_20240423_130344

Testing

  • Test ascending/descending icon changes appropriately for sort boxes: User Playists, Playlists, Video Comments, Channel, Playlist Add Video Prompt
  • Check that icon appears for all ft-selects

Desktop

  • OS: OpenSUSE
  • OS Version: TW

Additional context

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Apr 23, 2024
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) April 23, 2024 18:06
src/renderer/views/UserPlaylists/UserPlaylists.js Outdated Show resolved Hide resolved
src/renderer/views/Playlist/Playlist.js Outdated Show resolved Hide resolved
src/renderer/views/Playlist/Playlist.js Outdated Show resolved Hide resolved
src/renderer/views/Playlist/Playlist.js Outdated Show resolved Hide resolved
Co-authored-by: PikachuEXE <git@pikachuexe.net>
@FreeTubeBot FreeTubeBot merged commit d52ab88 into FreeTubeApp:development Apr 25, 2024
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Apr 25, 2024
@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

efb4f5ff-1298-471a-8973-3d47447115dc commented Apr 25, 2024

BUG!

How it looked like before

FreeTube_YNgeZAxmJ0.mp4

How it looks like now

VirtualBoxVM_K8Oq5THgEJ.mp4

@kommunarr
Copy link
Collaborator Author

So icon needs to disappear when the control is disabled. Got it. I will probably bundle this fix into a related PR if that's okay, as this is pretty minor

@efb4f5ff-1298-471a-8973-3d47447115dc

It also doesnt name the previous overwritten colors anymore. It just says primary and secondary color

@kommunarr kommunarr mentioned this pull request Apr 25, 2024
1 task
@efb4f5ff-1298-471a-8973-3d47447115dc

Sometimes the color pallete isnt updating the color under the Sponserblock settings

FreeTube_hBsN3DnEAV.mp4

@kommunarr
Copy link
Collaborator Author

Ah, I see, it's passing in the color name and not the actual value. It's a cute accident that it's actually working with the built-in CSS color names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Add icons to dropdowns
6 participants