Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow filtering searches by features #5125

Merged
merged 6 commits into from
May 27, 2024
Merged

Allow filtering searches by features #5125

merged 6 commits into from
May 27, 2024

Conversation

ChunkyProgrammer
Copy link
Member

@ChunkyProgrammer ChunkyProgrammer commented May 18, 2024 •
edited
Loading

Allow filtering searches by features

Pull Request Type

  • Feature Implementation

Description

YouTube and Invidious both support filtering videos by features. This PR adds support for it to FreeTube

Closes #3142

Screenshots

image
image

Testing

  • use search filters for searches with both invidious and local api
    ex:
  • test with both local api and invidious api
    • clear search cache in privacy settings
    • add vr180 filter and search roller coaster
    • you should see vr roller coaster videos
    • remove vr180 filter and search roller coaster
    • you should see non vr videos as well now (also 360 vr videos)

Desktop

  • OS: Linux Mint
  • OS Version: 21.3
  • FreeTube version: latest nightly

@ChunkyProgrammer ChunkyProgrammer marked this pull request as ready for review May 19, 2024 14:13
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label May 19, 2024
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) May 19, 2024 14:13
@absidue absidue added PR: changes requested and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels May 19, 2024
@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

Closes your own issue right?

#3142

@ChunkyProgrammer ChunkyProgrammer added PR: waiting for review For PRs that are complete, tested, and ready for review and removed PR: changes requested labels May 23, 2024
PikachuEXE
PikachuEXE previously approved these changes May 23, 2024
View reviewed changes
@ChunkyProgrammer @absidue
Remove unused prop
fd813b9 
Co-authored-by: absidue <48293849+absidue@users.noreply.github.com>
@FreeTubeBot FreeTubeBot merged commit 73be336 into FreeTubeApp:development May 27, 2024
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label May 27, 2024
@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

@ChunkyProgrammer thanks for implementing this and making us on par with YT again in terms of search filters. I know this is already merged and should have reviewed this earlier but this PR is missing one thing IMO.

Before this PR:
Search filters that could not be used with each other would reset to default state

With this PR:
Search filters do not reset if an incompatible Features search filter is applied

@ChunkyProgrammer ChunkyProgrammer deleted the feature-search branch May 31, 2024 12:43
@ChunkyProgrammer ChunkyProgrammer mentioned this pull request May 31, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kommunarr kommunarr kommunarr approved these changes

@absidue absidue absidue approved these changes

@PikachuEXE PikachuEXE PikachuEXE approved these changes

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc Awaiting requested review from efb4f5ff-1298-471a-8973-3d47447115dc

@MarmadileManteater MarmadileManteater Awaiting requested review from MarmadileManteater

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Add 'Features' Search Filter
6 participants
@ChunkyProgrammer @efb4f5ff-1298-471a-8973-3d47447115dc @PikachuEXE @absidue @kommunarr @FreeTubeBot