Cleanup unused channel hiding code in ft-list-video-numbered

[absidue]

Cleanup unused channel hiding code in ft-list-video-numbered

Pull Request Type

• Cleanup

Description

From what I could tell, we had a prop that allowed you to turn on channel hidding in the ft-list-video-numbered component, but it defaulted to false and in neither of the two places that we used the component, did we set that prop to true. So if it's not used, it doesn't seem worth keeping around. Initially I thought this would help with the performance problems experienced in #4578, but in my testing it didn't seem to make a difference, so I'm categorizing this pull request as a cleanup instead of a performance improvement.

FreeTube/src/renderer/components/watch-video-playlist/watch-video-playlist.vue

Lines 126 to 144 in b0b2af1

	<ft-list-video-numbered
	v-for="(item, index) in playlistItems"
	:key="item.playlistItemId || item.videoId"
	:ref="currentVideoIndexZeroBased === index ? 'currentVideoItem' : null"
	class="playlistItem"
	:data="item"
	:playlist-id="playlistId"
	:playlist-type="playlistType"
	:playlist-index="reversePlaylist ? playlistItems.length - index - 1 : index"
	:playlist-item-id="item.playlistItemId"
	:playlist-reverse="reversePlaylist"
	:playlist-shuffle="shuffleEnabled"
	:playlist-loop="loopEnabled"
	:video-index="index"
	:is-current-video="currentVideoIndexZeroBased === index"
	appearance="watchPlaylistItem"
	:initial-visible-state="index < (currentVideoIndexZeroBased + 4) && index > (currentVideoIndexZeroBased - 4)"
	@pause-player="pausePlayer"
	/>

FreeTube/src/renderer/views/Playlist/Playlist.vue

Lines 91 to 111 in b0b2af1

	<ft-list-video-numbered
	v-for="(item, index) in visiblePlaylistItems"
	:key="`${item.videoId}-${item.playlistItemId || index}`"
	class="playlistItem"
	:data="item"
	:playlist-id="playlistId"
	:playlist-type="infoSource"
	:playlist-index="playlistInVideoSearchMode ? playlistItems.findIndex(i => i === item) : index"
	:playlist-item-id="item.playlistItemId"
	appearance="result"
	:always-show-add-to-playlist-button="true"
	:quick-bookmark-button-enabled="quickBookmarkButtonEnabled"
	:can-move-video-up="index > 0 && !playlistInVideoSearchMode && isSortOrderCustom"
	:can-move-video-down="index < playlistItems.length - 1 && !playlistInVideoSearchMode && isSortOrderCustom"
	:can-remove-from-playlist="true"
	:video-index="playlistInVideoSearchMode ? playlistItems.findIndex(i => i === item) : index"
	:initial-visible-state="index < 10"
	@move-video-up="moveVideoUp(item.videoId, item.playlistItemId)"
	@move-video-down="moveVideoDown(item.videoId, item.playlistItemId)"
	@remove-from-playlist="removeVideoFromPlaylist(item.videoId, item.playlistItemId)"
	/>

Testing

Not sure what to put here for this pull request, maybe make sure that channels still aren't hidden inside playlists?

Desktop

• OS: Windows
• OS Version: 10
• FreeTube version: b0b2af1