Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump shaka-player from 4.10.12 to 4.11.1 #5677

Merged
merged 6 commits into from
Sep 15, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 9, 2024

Bumps shaka-player from 4.10.12 to 4.11.1.

Release notes

Sourced from shaka-player's releases.

v4.11.1

4.11.1 (2024-09-09)

Bug Fixes

  • Fix rendering of image subs when using SimpleTextDisplayer (#7258) (cafc7d1)
  • TTML: Fix subtitles not rendered due to complaint about xml:id (#7270) (51e8171)
  • UI: Display the font-family correctly in some cases (#7266) (7339ed5)
  • WebVTT: Fix mapNativeCueToShakaCue in Chromium browsers (#7273) (2b7c087)

v4.11.0

4.11.0 (2024-09-04)

Features

... (truncated)

Changelog

Sourced from shaka-player's changelog.

4.11.1 (2024-09-09)

Bug Fixes

  • Fix rendering of image subs when using SimpleTextDisplayer (#7258) (cafc7d1)
  • TTML: Fix subtitles not rendered due to complaint about xml:id (#7270) (51e8171)
  • UI: Display the font-family correctly in some cases (#7266) (7339ed5)
  • WebVTT: Fix mapNativeCueToShakaCue in Chromium browsers (#7273) (2b7c087)

4.11.0 (2024-09-04)

Features

Bug Fixes

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [shaka-player](https://github.com/shaka-project/shaka-player) from 4.10.12 to 4.11.1.
- [Release notes](https://github.com/shaka-project/shaka-player/releases)
- [Changelog](https://github.com/shaka-project/shaka-player/blob/v4.11.1/CHANGELOG.md)
- [Commits](shaka-project/shaka-player@v4.10.12...v4.11.1)

---
updated-dependencies:
- dependency-name: shaka-player
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added PR: dependencies Pull requests that update a dependency file PR: waiting for review For PRs that are complete, tested, and ready for review labels Sep 9, 2024
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) September 9, 2024 10:55
@efb4f5ff-1298-471a-8973-3d47447115dc

The one thing that bothers me is that the progress bar appears and directly disappears on the live stream which could confuse users and think something is broken. I think it shouldnt appear at all.

VirtualBoxVM_Ni9k0AUnsb.mp4

@PikachuEXE
Copy link
Collaborator

From what I can see configureUI is called before loaded event which you can read player.isLive()
Even addSeekBar is false it displays seek bar for a split second before it's hidden
Maybe move configureUI(true) just after ui = new shaka.ui.Overlay (but no idea how to get isLive)

Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 11, 2024

Sorry, only users with push access can use that command.

@absidue
Copy link
Member

absidue commented Sep 11, 2024

Still flashes briefly, but for a much shorter amount of time (we still need the availabilityWindowOverride so that shaka-player know you can't seek).

Copy link
Collaborator

@PikachuEXE PikachuEXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flashbang through the door!
image

@PikachuEXE
Copy link
Collaborator

@efb4f5ff-1298-471a-8973-3d47447115dc
Please review the new flashbang 💥

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flashbang approved!

@FreeTubeBot FreeTubeBot merged commit bedae6c into development Sep 15, 2024
6 checks passed
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/shaka-player-4.11.1 branch September 15, 2024 18:30
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Sep 15, 2024
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this pull request Sep 16, 2024
* development: (29 commits)
  Translated using Weblate (Flemish (West))
  Added translation using Weblate (Flemish (West))
  Translated using Weblate (Slovak)
  Improve history import performance and fix some bugs (FreeTubeApp#5666)
  Bump electron from 32.0.2 to 32.1.0 (FreeTubeApp#5710)
  Local API: Use IOS HLS manifest for livestreams (FreeTubeApp#5705)
  Translated using Weblate (Slovak)
  Translated using Weblate (Japanese)
  Bump the stylelint group with 2 updates (FreeTubeApp#5706)
  Bump swiper from 11.1.12 to 11.1.14 (FreeTubeApp#5709)
  Fix a few memory leaks while tearing down the player (FreeTubeApp#5698)
  Fix audio track selection (FreeTubeApp#5697)
  Bump shaka-player from 4.10.12 to 4.11.1 (FreeTubeApp#5677)
  Translated using Weblate (Czech)
  Translated using Weblate (Serbian)
  Translated using Weblate (Polish)
  Translated using Weblate (German)
  Translated using Weblate (Chinese (Simplified Han script))
  Bump express from 4.19.2 to 4.20.0 (FreeTubeApp#5687)
  Translated using Weblate (Turkish)
  ...
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this pull request Sep 16, 2024
* development: (74 commits)
  Translated using Weblate (Flemish (West))
  Added translation using Weblate (Flemish (West))
  Translated using Weblate (Slovak)
  Improve history import performance and fix some bugs (FreeTubeApp#5666)
  Bump electron from 32.0.2 to 32.1.0 (FreeTubeApp#5710)
  Local API: Use IOS HLS manifest for livestreams (FreeTubeApp#5705)
  Translated using Weblate (Slovak)
  Translated using Weblate (Japanese)
  Bump the stylelint group with 2 updates (FreeTubeApp#5706)
  Bump swiper from 11.1.12 to 11.1.14 (FreeTubeApp#5709)
  Fix a few memory leaks while tearing down the player (FreeTubeApp#5698)
  Fix audio track selection (FreeTubeApp#5697)
  Bump shaka-player from 4.10.12 to 4.11.1 (FreeTubeApp#5677)
  Translated using Weblate (Czech)
  Translated using Weblate (Serbian)
  Translated using Weblate (Polish)
  Translated using Weblate (German)
  Translated using Weblate (Chinese (Simplified Han script))
  Bump express from 4.19.2 to 4.20.0 (FreeTubeApp#5687)
  Translated using Weblate (Turkish)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants