Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create osmTagToNameMapping-it.ts #673

Merged
merged 6 commits into from
May 9, 2022
Merged

Conversation

dp7x
Copy link
Contributor

@dp7x dp7x commented Apr 20, 2022

Second file to translate into italian

Second file to translate into italian
translated till line 164
translated till line 340
translated till line 430
translated till line 590
Translation completed !
@zdila
Copy link
Member

zdila commented May 9, 2022

@dp7x please write me here if you are done with this pull request. Thank you!

@dp7x
Copy link
Contributor Author

dp7x commented May 9, 2022 via email

@zdila zdila merged commit e614f93 into FreemapSlovakia:develop May 9, 2022
@zdila
Copy link
Member

zdila commented May 9, 2022

@dp7x thanks, you can check it now.

Also if you can then please translate the following (you can do it as a comment here):

errorHtml:
      '<h1>Problem starting application</h1>' +
      '<p>Please make sure you are using recent version of a modern browser (Google Chrome, Firefox, Safari, Opera, Edge, Chromium, Vivaldi, Brave, …).</p>',
    nojsMessage:
      'JavaScript enabled browser is required to run this application.',
    loadingMessage: 'Loading…',

also:

      <h1>Application error</h1>
      <p>Ticket ID: ${id}.</p>
      <p>You can send ticket ID and steps how to reproduce the error to <a href="mailto:freemap@freemap.sk">freemap@freemap.sk</a>.</p>

...and two more files:

  • src/components/supportUsModal/translations/en.tsx
  • src/translations/en-shared.json

And finally, in the different project https://github.com/FreemapSlovakia/freemap-mapnik/blob/develop/legend.js:

  • add it: '...' below every en: '...'
  • also add IT translation as next parameter in lines like road('path', 'trail is mostly visible', 'trasa je väčšinou viditeľná', false, 2), -> road('path', 'trail is mostly visible', 'trasa je väčšinou viditeľná', '...italian translation...', false, 2), (there are many such lines, also with poi(..., landcover(... and maybe more. I will fix accidental syntax errors.

Thanks!

(PS: feel free to provide your name which should we put to the planned "credits" dialog)

@dp7x
Copy link
Contributor Author

dp7x commented May 9, 2022

Sure !
Just give me some time.
Here is the first part (sorry for the format but I don't know how to paste it as code):

errorHtml: '<h1>Problema nell''avvio dell''applicazione</h1>' + '<p>Per favore assicurati di utilizzare una versione recente di un browser moderno (Google Chrome, Firefox, Safari, Opera, Edge, Chromium, Vivaldi, Brave, …).</p>', nojsMessage: 'E'' richiesto un browser con JavaScript abilitato per avviare questa applicazione.', loadingMessage: 'Caricamento…',

@dp7x
Copy link
Contributor Author

dp7x commented May 9, 2022

<h1>Errore dell''applicazione</h1> <p>Ticket Nr.: ${id}.</p> <p>Puoi inviare il tuo numero di ticket e i passaggi per riprodurre l''errore a <a href="mailto:freemap@freemap.sk">freemap@freemap.sk</a>.</p>

@dp7x
Copy link
Contributor Author

dp7x commented May 9, 2022

Please note: I used double '' but I don't know if it is needed in the code.
Just one ' is needed in the translation.
For example:
Errore dell'applicazione
is the correct translation

@dp7x
Copy link
Contributor Author

dp7x commented May 9, 2022

Ok, I created 2 pull requests for :

src/components/supportUsModal/translations/en.tsx
src/translations/en-shared.json

and started working on
https://github.com/FreemapSlovakia/freemap-mapnik/blob/develop/legend.js:

Check them and let me know.
About the "credits" dialog, I appreciate it very much and will write to you in private.
Thank you !

@dp7x
Copy link
Contributor Author

dp7x commented Jun 10, 2022

Hello Martin
the translation of LEGEND.JS is (finally...) complete !
Please check the code to see if there are any errors.

thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants