ConfigTool: General Widget update #610
Conversation
|
Which layout is better? Should there be spacing between the regular preferences and the "Reset" section to indicate that it's not really a setting itself?
|
|
Also, should both of the reset/clear buttons create confirmation dialogs before completing their action? |
farazs
force-pushed
the
update-configtool-general
branch
from
4281404
to
92694dd
Compare
|
So I added the functionality for "Clear talks", but the problem is that the configtool doesn't have access to the talk editor to tell it to reload the database. Right now I've made it so that every time the talk editor is launched from the record tool it calls select() on the presentationModel of the talk editor. Is this too much unnecessary work if there are no changes to the talks? An alternative would be to add a "dirty" bool to the database, which the talk editor can check every time it's show() method gets called. If the dirty is true then it can call select() to reload the presentationModel, otherwise not? |
|
I added the necessary calls to translate() for the new text, titles etc. What's the protocol for adding new/different text in terms of translation? Should I just add the calls to translate as I have now? Should I also populate the entries in the English translation file? Or do I have to add blank entries in the other translation files as well? |
|
Yes clearing talks is a function of the talk editor not configuration. |
|
Okay, I removed the clear talks option. I also have two options for the Reset section layout. Right now it's set to the first one. Is there anything else that needs to be done?
|
|
Changed the button sizes a bit and the confirmation dialog string. Screenshots: |
| # | ||
| self.confirmResetDefaultsTitleString = self.app.translate("ConfigToolApp", "Reset to Defaults") | ||
| self.confirmResetDefaultsQuestionString = self.app.translate("ConfigToolApp", | ||
| "Are you sure you want to restore all settings to their defaults?") |
There was a problem hiding this comment.
All params should be aligned if you split them across multiple lines.
|
@mtomwing Okay, changed everything like you asked. I also went and refactored the AVWidget init so that there aren't any unnecessary class variables there either. EDIT: There seems to be an issue with the Travis build. Looking into it now. |
farazs
force-pushed
the
update-configtool-general
branch
from
620272f
to
377252d
Compare
|
For whatever reason my "help us translate" button doesn't seem to have any left/right padding |
|
Seems to be good now. |
farazs
force-pushed
the
update-configtool-general
branch
from
75843d0
to
aa60003
Compare
|
Merge time? |
|
Nice work @farazs. I have some feedback on the reset section (may have feedback for the code as well, still need to look at it). We can make it a bit more user friendly. To add more information before the prompt, I think changing "Reset Settings" to "Reset settings to defaults" will make users feel more comfortable pressing the button since they now have a better idea what it does (and they don't know that there is a prompt with more info). For the prompt: "Defaults" doesn't need to be capitalized in the window title, but if you disagree then you can leave it. The description can be a bit more descriptive. E.g.
The actions can be more descriptive as well. [Reset] [Cancel] (with cancel being default) |
|
I looked at a bunch of prompts from programs I use often ie. chrome, utorrent etc. and they all seem to follow the pattern of I can make the title "Reset to defaults" or even "Freeseer", it shouldn't matter too much. I don't think anyone actually ever looks at it when a prompt comes up. For the message, I'm not sure if we want the user to be reading tons (or if they will even read it). Resetting settings to defaults is pretty self-explanatory imo. I could make the message something like "All your Freeseer settings will be restored to their defaults. Are you sure?". But I don't know if enumerating all the settings it will reset is helpful since we do say all. What do you think? And I think the actions have to be from QMessageBox but I agree, it should be "Okay" and "Cancel" since that seems more appropriate for an action like this. (Nvm, just noticed there's a Reset option) Edit: And yeah i'll change the button name to "Reset settings to defaults" so that it's more clear before the user presses it. |
|
@dideler How about a title of "Freeseer", a message of "Your Freeseer settings will be restored to their original defaults." and "Reset" and "Cancel" buttons? |
|
Something weird happens when I use Reset. But Yes, No, Okay and Cancel all work fine. Here's what happens: |
farazs
force-pushed
the
update-configtool-general
branch
from
aa60003
to
9724a1a
Compare
Improved the overall layout of the General tab. Added "Reset Settings" and "Help us translate" buttons. Some refactoring to remove unnecessary instance variables.
farazs
force-pushed
the
update-configtool-general
branch
from
9724a1a
to
4a462cb
Compare
|
Merged in 19f959d. I ended up going with the Reset/Cancel button combo. |
|
Thanks for your contribution! |
This doesn't seem to be the case when I check Chrome.
A UX rule of thumb is to stay away from button labels like "Yes", "No", "OK". You should try to be specific (e.g. a call to action) yet keep it concise. Reading the button should remind the user what action will take place. See http://ux.stackexchange.com/questions/9946/should-i-use-yes-no-or-ok-cancel-on-my-message-box (or any search about button labels WRT to UX will bring up similar results).
I do think saying what will be reset is useful, but in this case I've changed my mind because I think there would be too many things to mention. If there were only a few settings or we could word it so that it's not a lot of text then the extra information would help, but currently we risk putting too much text which dilutes the message. |
|
The dialogs I checked were things like opening all bookmarks and stuff like that. In my opinion, something like resetting all settings is a way bigger deal in Chrome than in Freeseer. So if a user really wants to reset all their settings in Chrome they should be informed about all the changes that will occur but I don't think the same should be true for Freeseer. Recovering from an unintentional reset in Chrome would take a lot longer than in Freeseer. Yeah I agree that having "Reset" would be better than "Okay" if all else were equal. But the user expects dialogs to have both options on the right hand side, and when the Reset option is set, it goes all the way to the left hand size (as shown in the screenshots in my earlier post). Imo the downside of the unintuitive layout is greater than the upside of the better wording. But it's upto you guys in the end and I think you ended up merging with "Reset" instead of "Okay" which is fine too. |
Fix #539
Tasks: