prevent massive performance drop on canvas mouseout by ignoring… #1356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… events that take place out of game
|
I've checked the performance like you said and there's quite a difference, well done! |
CyberBishop
pushed a commit
to CyberBishop/AncientBeast
that referenced
this pull request
Apr 20, 2023
prevent massive performance drop on canvas mouseout, fixes FreezingMoon#1352
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… events that take place out of game
issue #1352
to test, use chrome's devtools to monitor performance when moving mouse between UI and game canvas. you should note a sharp performance decrease when doing so. then, check the same on this PR and note that the performance drop has disappeared!