1106 - Bunny Hop triggers however an enemy comes into proximity with the Bunny

[nandastone]

This MR allows the Bunny Hop ability to trigger when:

• an enemy enters the 3 hexes in front of the Bunny (already worked)
• the Bunny is displaced and now has an enemy within the 3 hexes in front of the Bunny (new)

When Bunny is frozen:

[gitpod-io]

[nandastone]

@DreadKnight Are there any other displacement type abilities I should test this with?

[DreadKnight]

Not really. Basically a friend or foe could move an enemy unit in front of Snow Bunny, which should trigger the passive.
Scavenger can use Escort Service ability to move units around.

[nandastone]

MR updated, see my comment below: #1939 (comment)

[DreadKnight]

@nandastone I've left review regarding Scavenger's Escort Service. So the passive shouldn't work just vs active units.
There are also some abilities with knockback, Like Swine Thung's Baseball bat or Uncle Fungus' upgraded Sabre Kick.
Chimera's Battering Ram, Nutcase's upgraded Horn Head, also his Fishing Hook deals with moving around enemies.
So allied units could kick enemies closer to Snow Bunny, possibly causing him to scare away, because he's very fearful.

[nandastone]

@DreadKnight MR updated. Examples:

Regular hop:

Angled hop:

Whip Move displacing hop:

Escort Service displacing hop:

Escort service between two enemies hop:

Escort service between two enemies double hop (upgraded):

Baseball baton hop:

Invalid move no hop:

Angled fallback hop:

---

Interested to know if any of my functions for determining enemy position could be replaced with existing helper functions in the codebase.

[DreadKnight]

Seems you had quite the fun with this. So far tests are pretty good. There are situation where Bunny hops twice when he could have hopped just once to get out of danger, but that's fine, as it would rather become way more complex and we'll just assume he's not thinking straight so definitely not making the best and most efficient moves. Regarding helper function, maybe when abilities will get revamped and become modular as of issue #1469 in order to have an API and avoid reinvesting the wheel so much. Great job once again! 👏🏻 I'll merge this and will just open new issues if I do happen to find some given time, we'll see.