-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(database/influxdb2): Add database support of influxdb2 client #203
Conversation
Picked from FreifunkBremen/yanic#203 . (This PR is not yet merged)
Hey @genofire konntest du dir das nochmal anschauen? |
7352bd1
to
ff42378
Compare
0dcd55a
to
f3d6a68
Compare
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #203 +/- ##
==========================================
- Coverage 73.11% 66.22% -6.89%
==========================================
Files 55 59 +4
Lines 2418 2742 +324
==========================================
+ Hits 1768 1816 +48
- Misses 598 872 +274
- Partials 52 54 +2
|
169f30d
to
7c01dcb
Compare
greate, hope i do not drift away, and maybe write testcases, then i could merge it :) here i found fakeclient: https://github.com/influxdata/influxdb-client-go/blob/master/internal/examples/fakeclient.go |
7caf8dc
to
2cab4e4
Compare
docs/docs/configuration.md
Outdated
!!! warning | ||
yanic do NOT prune nodes data (so please setup it in InfluxDB2 setup). | ||
|
||
We hightly recommend to setup e.g. [Data retention](https://docs.influxdata.com/influxdb/v2/reference/internals/data-retention/) in InfluxDB2 server per measurements. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AiyionPrime, @1977er and @maurerle do you have example code, to setup such data retention?
Do you like to give feedback about my documentation?
472aa22
to
bdafa98
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed the docs.
I currently can't test this due to time constraints.
global = "yanic" | ||
#firmware = "yanic-temp" | ||
#model = "yanic-temp" | ||
#autoupdater = "yanic-temp" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't the default documentation show that all measurements are written?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change it yo bucket_default = yanic and here global = yanic-persistent ... good point
Thank you for your review :) |
What is the state of this PR? @AiyionPrime are you still using this (and also in the current version?)? Have you had any problem? |
I think so. Will check after work. Maybe not today; we'll be climbing until late. |
After reading a bit more about influxdb i'm not quite sure wheter v2 is even the way to go with it seemingly already beeing more or less in the same somewhat abandoned state as v1 and v3 beeing yet another rewrite. |
This is what "we" are using with influx2. Not sure, if this is that. No current problems. |
🎉 This PR is included in version 1.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Description
Major changes happens in InfluxDB on version 2, lets update the API dependencies.
Motivation and Context
fixes #202
Checklist: