Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] add job tag to influxdb database type #44

Merged
merged 4 commits into from
Jun 1, 2017

Conversation

kb-light
Copy link
Contributor

This patch adds the posibility, to add an additional tag (called job) to influx data. This may be helpful if you are running multiple sites .

@genofire
Copy link
Member

genofire commented Mar 16, 2017

Top 👍
https://github.com/influxdata/telegraf use hostname for this, but this is already take by node as example.

But could you make job optional, on a way, that no tag would created if job is empty?

@corny
Copy link
Member

corny commented Mar 16, 2017

Why is a site tag not sufficient? see #26
job ist quite meaningless.

@kb-light
Copy link
Contributor Author

I have chosen job, because there was something similar within prometheus, but it is just an name, that can be changed. One may run multiple instances on the same host, so hostname does not suit either. One may call it site, but in my opinion, this has nothing to do with the gluon site_code:

  • One can run multiple instances within the same network
  • When moving to Batman-adv v15, one may has to mesh networks with the same site_code
  • Or one has nodes with different site_code in the same mesh

I agree with making this optional.

@genofire
Copy link
Member

genofire commented Mar 16, 2017

It is just a tag for saving by yanic process.
It could be use for job = "productive" and job = "testing" as well.
So there could work another yanic instance on the same influxdb database.

Beside the idea to use it for sites. I found this idea good.

@genofire genofire changed the title add job tag [TASK] add job tag Mar 16, 2017
@genofire
Copy link
Member

genofire commented Mar 16, 2017

also ich find es klasse -> von mir aus kann es ge squash-merge werden
@corny okay?

@corny
Copy link
Member

corny commented Mar 16, 2017

Wie wär's, einfach eine Map von Tags in die Konfiguration schreiben zu können? Dann brauchen wir uns nicht über die Benennung Gedanken machen und haben maximale Flexibilität.

@genofire
Copy link
Member

Ist das nicht etwas viel? job ist doch relativ neutral.

Doch dann müsste eine überprüfung stattfinden, ob der tagnamen nicht bereits von uns belegt ist.
Wie z.B. hostname

@genofire
Copy link
Member

Liegt schon etwas lange hier rum, hab daher mal den Wunsch implementiert.

@coveralls
Copy link

coveralls commented May 20, 2017

Coverage Status

Coverage increased (+1.4%) to 57.688% when pulling abefd06 on kb-light:job-tag into d20277a on FreifunkBremen:master.

@genofire genofire mentioned this pull request May 20, 2017
@coveralls
Copy link

coveralls commented May 22, 2017

Coverage Status

Coverage increased (+1.2%) to 57.688% when pulling ccc1047 on kb-light:job-tag into dc24c8b on FreifunkBremen:master.

@kb-light
Copy link
Contributor Author

Würde dieses Feature immer noch gerne Upstream sehen. Ob da jetzt nur der job-Tag möglich ist oder man gleich eine ganze Liste an Tags definieren kann, ist mir egal (solange ich den bereits gewählten Tag durch entsprechende Konfiguration weiternutzen kann).

@genofire genofire mentioned this pull request Jun 1, 2017
6 tasks
@genofire genofire changed the title [TASK] add job tag [TASK] add job tag to influxdb database type Jun 1, 2017
@genofire genofire merged commit 214a038 into FreifunkBremen:master Jun 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants