[TASK] improve output (filtering, fix links type, new outputs nodelist for freifunkapi and meshviewer-ffrgb v10 NextGen) #63

genofire · 2017-05-20T12:47:24Z

should fix also

filter values (Remove incomplete geo locations #51)
link with more values and fix vpn detection (Rewrite types of link in graph.json #45)
new output format
- nodelist (the minimal version for the freifunkapi
- for meshviewer-ffrgb (Support new meshviewer(-ffrgb) file-format #74)

corny

Warum akzeptieren die filter* Funktionen einen nil-Parameter und warum geben sie etwas anderes als bool zurück? Bitte überdenken!

corny · 2017-10-16T22:24:48Z

output/all/filter.go

+	xA float64
+	xB float64
+	yA float64
+	yB float64


Wieso unterschiedliche Bezeichnungen? Hier x und y und dort latitude und longitude?
Vier Punkte in einem zweidimenionalen Raum können was ganz anderes sein....

corny · 2017-10-16T22:26:47Z

output/all/filter.go

+					return node
+				}
+			} else {
+				if location := nodeinfo.Location; location == nil {


bitte entschachteln

corny · 2017-10-16T22:27:24Z

output/all/filter.go

+	return nil
+}
+
+func filterLocationInArea(node *runtime.Node, a area) *runtime.Node {


Warum sollte nil an diese Funktion übergeben werden?

corny · 2017-10-16T22:28:29Z

output/all/internal.go

+	for outputType, outputRegister := range output.Adapters {
+		outputConfigs, ok := allOutputs[outputType].([]map[string]interface{})
+		if !ok {
+			continue


Einfach ignorieren, wenn nicht ok ?

Du meinst man sollte erst aus der map lesen und dann den Objekttypen wandlen ( wobei dann ein panic geworfen wird?

Die Frage ist: Erwartet ein Anwender von Yanic, dass eine fehlerhafte Konfiguration stillschweigend akzeptiert wird? Was ist hilfreich?

corny · 2017-10-16T22:29:31Z

output/all/internal.go

+		filteredNodes := nodes
+		if config, ok := o.filter[i]; ok {
+			filteredNodes = config.filtering(nodes)
+		}


was wenn nicht ok?

UPS, ist mir auch noch gestern eingefalleeingefallen, das dann der owner nicht standartdmäßig weggefilter wird.

corny · 2017-10-16T22:31:17Z

output/internal_test.go

+
+	Close()
+
+	time.Sleep(time.Millisecond * 12) // to reach timer.Stop() line


Hier brauchst du nicht schlafen, wenn du WaitGroups benutzt.

corny · 2017-10-16T22:34:07Z

output/meshviewer-ffrgb/output.go

+
+func Register(configuration map[string]interface{}) (output.Output, error) {
+	var config Config
+	config = configuration


weshalb struct kopieren?

Damit ein typumwandlung stattfinden - meinst das sollte auch im funktionskopf möglich sein?

corny · 2017-10-16T22:36:07Z

output/meshviewer/output.go

+var nodeFormats = map[int64]nodeBuilder{
+	1: BuildNodesV1,
+	2: BuildNodesV2,
+}


Wie wäre es mit zwei output-Plugins für die Versionen?

Dann wären zweimal der graph builder notwendig,
auch wenn der vom anderen Plugin importierbar wäre.
(Ist für mich nicht DRY)
Außerdem ist es für die History der Meshviewer interessant. (Die Version 1 und 2 stammen ja aus ffnord)

corny · 2017-10-16T22:38:52Z

output/meshviewer-ffrgb/output.go

+		return enable.(bool)
+	}
+	return false
+}


Diese Funktion gibt es vier mal in zwei unterschiedlichen Schreibweisen. Geht das auch DRY?

corny · 2017-10-16T22:42:22Z

output/all/filter.go

+	if v, ok := f["no_owner"]; ok {
+		return v.(bool)
+	}
+	return true


das geht kürzer

genofire · 2017-10-17T07:27:32Z

Danke für die Anregungen

codecov-io · 2017-10-19T12:07:52Z

Codecov Report

Merging #63 into master will increase coverage by 13.93%.
The diff coverage is 99.45%.

@@             Coverage Diff             @@
##           master      #63       +/-   ##
===========================================
+ Coverage   59.43%   73.36%   +13.93%     
===========================================
  Files          24       37       +13     
  Lines         843     1164      +321     
===========================================
+ Hits          501      854      +353     
+ Misses        323      299       -24     
+ Partials       19       11        -8

Impacted Files	Coverage Δ
output/meshviewer/node.go	`100% <ø> (ø)`
data/nodeinfo.go	`0% <ø> (ø)`	⬆️
runtime/config.go	`100% <ø> (ø)`	⬆️
respond/collector.go	`26.41% <0%> (-2.25%)`	⬇️
output/output.go	`100% <100%> (ø)`
runtime/nodes.go	`92.8% <100%> (+0.49%)`	⬆️
output/internal.go	`100% <100%> (ø)`
output/all/filter_noowner.go	`100% <100%> (ø)`
output/all/filter.go	`100% <100%> (ø)`
runtime/stats.go	`100% <100%> (ø)`	⬆️
... and 30 more

genofire · 2017-10-25T21:54:05Z

link source+target in map -> deletes other links to target
target-tq should be source-tq if not set

genofire · 2017-10-27T15:18:39Z

output/internal_test.go

 	Close()
-	assert.Equal(1, conn.CountSave)


Hab keine Erklärung, wie hier jemals eine 0 entstehen kann ->
https://travis-ci.org/FreifunkBremen/yanic/jobs/293724350#L529

xf- · 2017-10-31T09:45:31Z

output/meshviewer-ffrgb/struct.go

-	Enabled bool   `json:"enabled,omitempty"`
-	Branch  string `json:"branch,omitempty"`
+	Enabled bool   `json:"enabled"`
+	Branch  string `json:"branch"`


i think branch is fine omitempty

corny

Bitte wirf das template Output-Plugin raus. Der Nutzen erschließt sich mir nicht.

…t for freifunkapi and meshviewer-ffrgb v10 NextGen)

corny · 2017-11-01T09:23:17Z

config_example.toml

+enable   = true
+path = "/var/www/html/meshviewer/data/meshviewer.json"
+
+


Du verwendest mal doppelte und mal einfache Klammern für die Sections. Hat das einen Grund?

Doch, das sind Array-Einträge mit "[[...]]" dadurch können mehrere datenbanken oder outputs configuriert werden.
z.B. output ohne Filter und eine mit Filter, das owner angezeigt wird (für eine hidden Meshviewer)
oder ein Meshviewer nur für Walle, um die auf deren Seite einzubinden.
... es gibt viele Möglichkeiten

Dann erkläre das bitte in der Config-Datei.

…t for freifunkapi and meshviewer-ffrgb v10 NextGen) - #63

genofire mentioned this pull request May 20, 2017

Increase Testcoverage #64

Closed

genofire requested a review from corny May 20, 2017 15:00

genofire force-pushed the file-output branch from 0e64e82 to 47e045c Compare May 22, 2017 10:21

genofire added review wip and removed review labels Jun 1, 2017

genofire force-pushed the file-output branch from f5afacf to ef726a5 Compare June 14, 2017 19:36

FreifunkBremen deleted a comment from coveralls Sep 12, 2017

FreifunkBremen deleted a comment from coveralls Sep 27, 2017

genofire force-pushed the file-output branch 5 times, most recently from 281d79b to 7da7b07 Compare October 15, 2017 21:50

FreifunkBremen deleted a comment from codecov-io Oct 15, 2017

genofire added review and removed wip labels Oct 15, 2017

genofire force-pushed the file-output branch from 7da7b07 to dfd7523 Compare October 15, 2017 23:01

FreifunkBremen deleted a comment from codecov-io Oct 15, 2017

genofire force-pushed the file-output branch from 6aa4bd6 to 49e8597 Compare October 16, 2017 07:04

genofire mentioned this pull request Oct 16, 2017

Add support for hopglass nodes.json and graph.json #50

Closed

genofire force-pushed the file-output branch from 007a4b8 to cd72811 Compare October 16, 2017 21:17

corny requested changes Oct 16, 2017

View reviewed changes

genofire added wip and removed review labels Oct 17, 2017

FreifunkBremen deleted a comment from codecov-io Oct 18, 2017

genofire force-pushed the file-output branch from 90b1105 to ee8eb94 Compare October 19, 2017 12:02

genofire added review and removed wip labels Oct 19, 2017

genofire changed the title ~~[TASK] improve output (to stats page and filtering in meshviewer)~~ [TASK] improve output (filtering, fix links type, new outputs stats page, nodelist for freifunkapi, meshviewer ffrgb NextGen) Oct 19, 2017

genofire mentioned this pull request Oct 22, 2017

[TASK] Add script to remove nodes by nodeid #81

Merged

genofire force-pushed the file-output branch from ee8eb94 to f85fe60 Compare October 26, 2017 13:31

genofire commented Oct 27, 2017

View reviewed changes

genofire mentioned this pull request Oct 30, 2017

Improve configuration for plugins (database and output) #85

Closed

xf- reviewed Oct 31, 2017

View reviewed changes

genofire mentioned this pull request Oct 31, 2017

[DOC] fix grammar in INSTALL.md and config_example.toml #86

Merged

corny requested changes Oct 31, 2017

View reviewed changes

genofire force-pushed the file-output branch 2 times, most recently from 616596d to da6096e Compare October 31, 2017 22:39

genofire changed the title ~~[TASK] improve output (filtering, fix links type, new outputs stats page, nodelist for freifunkapi, meshviewer ffrgb NextGen)~~ [TASK] improve output (filtering, fix links type, new outputs nodelist for freifunkapi + meshviewer-ffrgb NextGen) Oct 31, 2017

genofire force-pushed the file-output branch from da6096e to ea24351 Compare November 1, 2017 07:48

genofire changed the title ~~[TASK] improve output (filtering, fix links type, new outputs nodelist for freifunkapi + meshviewer-ffrgb NextGen)~~ [TASK] improve output (filtering, fix links type, new outputs nodelist for freifunkapi and meshviewer-ffrgb v10 NextGen) Nov 1, 2017

genofire force-pushed the file-output branch 2 times, most recently from 0041925 to 0bed780 Compare November 1, 2017 08:00

[TASK] improve output (filtering, fix links type, new outputs nodelis…

8bee4b6

…t for freifunkapi and meshviewer-ffrgb v10 NextGen)

genofire force-pushed the file-output branch from 0bed780 to 8bee4b6 Compare November 1, 2017 08:13

corny reviewed Nov 1, 2017

View reviewed changes

[DOC] config-file

41b4683

corny merged commit 46d07c5 into master Nov 1, 2017

corny deleted the file-output branch November 1, 2017 10:31

genofire added a commit that referenced this pull request Nov 1, 2017

[TASK] improve output (filtering, fix links type, new outputs nodelis…

82fa527

…t for freifunkapi and meshviewer-ffrgb v10 NextGen) - #63

This was referenced Nov 1, 2017

Support new meshviewer(-ffrgb) file-format #74

Closed

Remove incomplete geo locations #51

Closed

Rewrite types of link in graph.json #45

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TASK] improve output (filtering, fix links type, new outputs nodelist for freifunkapi and meshviewer-ffrgb v10 NextGen) #63

[TASK] improve output (filtering, fix links type, new outputs nodelist for freifunkapi and meshviewer-ffrgb v10 NextGen) #63

genofire commented May 20, 2017 •

edited

Loading

corny left a comment

corny Oct 16, 2017

corny Oct 16, 2017

corny Oct 16, 2017

corny Oct 16, 2017

genofire Oct 17, 2017

corny Oct 17, 2017

corny Oct 16, 2017

genofire Oct 17, 2017

corny Oct 16, 2017

corny Oct 16, 2017

genofire Oct 17, 2017

genofire Oct 18, 2017

corny Oct 16, 2017

genofire Oct 17, 2017

corny Oct 16, 2017

corny Oct 16, 2017

genofire commented Oct 17, 2017

codecov-io commented Oct 19, 2017 •

edited

Loading

genofire commented Oct 25, 2017 •

edited

Loading

genofire Oct 27, 2017 •

edited

Loading

xf- Oct 31, 2017

corny left a comment

corny Nov 1, 2017

genofire Nov 1, 2017

genofire Nov 1, 2017

corny Nov 1, 2017


		Close()

		time.Sleep(time.Millisecond * 12) // to reach timer.Stop() line

		enable = true
		path = "/var/www/html/meshviewer/data/meshviewer.json"

[TASK] improve output (filtering, fix links type, new outputs nodelist for freifunkapi and meshviewer-ffrgb v10 NextGen) #63

[TASK] improve output (filtering, fix links type, new outputs nodelist for freifunkapi and meshviewer-ffrgb v10 NextGen) #63

Conversation

genofire commented May 20, 2017 • edited Loading

corny left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

genofire commented Oct 17, 2017

codecov-io commented Oct 19, 2017 • edited Loading

Codecov Report

genofire commented Oct 25, 2017 • edited Loading

genofire Oct 27, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

corny left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

genofire commented May 20, 2017 •

edited

Loading

codecov-io commented Oct 19, 2017 •

edited

Loading

genofire commented Oct 25, 2017 •

edited

Loading

genofire Oct 27, 2017 •

edited

Loading