Fix Swage theme issues #2088
Merged
Fix Swage theme issues #2088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix highlighting issue in Config pages, prepare for variable-width config buttons
Add ID's to be able to individually target buttons inside the configure feeds (Subscriptions Management & Import/Export) buttons.
|
@Alkarex sure, that's simple enough, just have to pull out a single line of CSS from the theme. I don't use scroll to mark as read, so I didn't realize that that was affecting a feature. Want a PR specifically for that, or should I wait until 12.1 is closer and roll it in as part of a PR fixing other issues that might pop up with the theme? I don't want to clutter up the queue with a bunch of single or couple line PR's if it's going to annoy anyone. |
|
Yes please, another PR is fine. Too many PRs are not a problem (yet) :-) |
|
I'll get it to you a bit later on, then! |
Merged
javerous
pushed a commit
to javerous/FreshRSS
that referenced
this pull request
Jan 20, 2020
Fix Swage theme issues
javerous
pushed a commit
to javerous/FreshRSS
that referenced
this pull request
Jan 20, 2020
mdemoss
pushed a commit
to mdemoss/FreshRSS
that referenced
this pull request
Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed the issue with the active tab not being highlighted in the config view.
In order to make the configure-feeds buttons be able to adapt to fill the width of the aside, I had to add ID tags to them, as without this change, I couldn't target the buttons individually, and the only solution would be to make each button 50% the width of the aside, a less than ideal solution that would cut text in pretty much any language (except possibly languages which use logograms instead of alphabets).
Ideally, I'd like to add ID's to all of the UI components, which would greatly increase the themeability of FreshRSS without breaking any existing themes, but that's not work I'm going to take on without any sort of discussion first.