Changes in Swage theme for Mark As Read on Scroll #2094
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove theme sizing to make scroll as read work per #1980, as requested in #2088 (comment)
I just want to say that I really don't like this solution; it doesn't seem intuitive to me if scroll to mark as read is enabled, and looks downright broken if you don't, which is why I'd overridden the height in the first place. I'll be adding looking into another way to do this to my personal to-do list.