Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes in Swage theme for Mark As Read on Scroll #2094

Merged
merged 1 commit into from
Oct 30, 2018
Merged

Conversation

pattems
Copy link
Contributor

@pattems pattems commented Oct 30, 2018

Remove theme sizing to make scroll as read work per #1980, as requested in #2088 (comment)

I just want to say that I really don't like this solution; it doesn't seem intuitive to me if scroll to mark as read is enabled, and looks downright broken if you don't, which is why I'd overridden the height in the first place. I'll be adding looking into another way to do this to my personal to-do list.

Remove theme sizing to make scroll as read work per FreshRSS#1980
@Alkarex
Copy link
Member

Alkarex commented Oct 30, 2018

Thanks. Alternative suggestions welcome.
By the way, for me, when it comes to scrolling, the most urgent is to find a more elegant way to decouple the list of feeds (on the left) and the list of articles (on the right) to allow scrolling down to the bottom of a long list of feeds without scrolling the articles, and thus without auto-marking them as read

@Alkarex Alkarex added the UI 🎨 User Interfaces label Oct 30, 2018
@Alkarex Alkarex added this to the 1.13.0 milestone Oct 30, 2018
@Alkarex Alkarex merged commit 9b86671 into FreshRSS:dev Oct 30, 2018
@pattems
Copy link
Contributor Author

pattems commented Oct 31, 2018

A simple decoupling could be done by just removing sticky-kit, and would leave the feed list at the top, like the behavior of feeds in versions prior to... 1.5, it looks like (#1214)?

Without sticky-kit, individual scrolling of the sidebar and main feeds could be accomplished purely through css. I've tossed together a quick proof-of-concept here: https://github.com/pattems/FreshRSS/tree/Sticky_aside

This isn't a terribly robust solution, however. There's problems with the last feed or two being obscured by nav buttons if they're visible, but with a bit more work it's a viable, if slightly hacky, pure-css solution.

I'm not terribly good with Javascript, but I think I can probably throw together a JS replacement for sticky-kit that will let us have those decoupled feeds, it might just need a little extra polishing by more capable hands after I'm done with it. I'm not making any promises, but I hope to have something together by My Friday evening/Your Saturday morning.

Alkarex added a commit that referenced this pull request Nov 11, 2018
@Alkarex Alkarex mentioned this pull request Dec 16, 2018
javerous pushed a commit to javerous/FreshRSS that referenced this pull request Jan 20, 2020
Remove theme sizing to make scroll as read work per FreshRSS#1980
mdemoss pushed a commit to mdemoss/FreshRSS that referenced this pull request Mar 25, 2021
Remove theme sizing to make scroll as read work per FreshRSS#1980
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI 🎨 User Interfaces
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants