Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dropdown being obscured by other elements #2089

Merged
merged 1 commit into from
Oct 30, 2018

Conversation

pattems
Copy link
Contributor

@pattems pattems commented Oct 29, 2018

I noticed that in every theme but Swage (and I can't quite figure out what my own theme's doing differently that makes this a non-issue), the properties tile of the theme select slider floats over the menu on a small screen, like so:

image

massively increasing the dropdown-menu's z-index will ensure that it should stay on top of everything; if this solution's non-ideal for some reason, .nav label's z-index could be reduced from 11 to 9, and properties' z-index could be reduced to 8.

increased z-index of dropdown-menu to prevent it from being obscured by other page elements
@Frenzie
Copy link
Member

Frenzie commented Oct 29, 2018

Don't forget to check overflow before going all in on z-index.

(Generic remark; haven't looked yet.)

@Alkarex Alkarex added this to the 1.13.0 milestone Oct 29, 2018
@Alkarex Alkarex added the UI 🎨 User Interfaces label Oct 29, 2018
@pattems
Copy link
Contributor Author

pattems commented Oct 29, 2018

@Frenzie are you talking about checking if the overlapping tile was overflowing, causing it to draw on top of the dropdown? That's not the case, if that's what you're talking about. Otherwise, I don't think I understand what you mean.

@Frenzie
Copy link
Member

Frenzie commented Oct 29, 2018

@pattems Apologies, I slightly misinterpreted the issue on my phone.

Looking at it I don't really understand why .properties has a z-index other than the default at all?

Anyway, note that you can also use things like inherit 1 (1 higher than parent) instead of absolute values in z-index stacks.

@pattems
Copy link
Contributor Author

pattems commented Oct 29, 2018

I don't really understand why .properties has a z-index specified either. Everything in the slider seems to work fine without setting any z-indexes at all, but since I didn't understand why they were there, I opted for not touching them, in case there's some really important reason that's just not immediately evident.

In the template.css file, there's nothing up the chain for .dropdown-menu to inherit a z-index from. the only z-index in the dropdown menu path in template.css is

.dropdown-target:target ~ .dropdown-menu {
display: block;
z-index: 10;
}

Also, as way of check, I copied the base-theme to a theme so I could check it raw, making sure it wasn't just a persistent issue with all the themes:

image

In any case, my rationale for a z-index of 1000 is to be high enough up the z-index that it should float above anything else in any theme, as one would expect for a pop-up menu; I can't think of a better way of ensuring that it stays on top of everything else.

@Alkarex Alkarex merged commit a605791 into FreshRSS:dev Oct 30, 2018
@pattems pattems deleted the template-fix branch October 30, 2018 14:58
Alkarex added a commit that referenced this pull request Nov 11, 2018
@Alkarex Alkarex mentioned this pull request Dec 16, 2018
javerous pushed a commit to javerous/FreshRSS that referenced this pull request Jan 20, 2020
Fix Dropdown being obscured by other elements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI 🎨 User Interfaces
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants