Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: Dutch #950

Merged
merged 4 commits into from
Aug 24, 2015
Merged

i18n: Dutch #950

merged 4 commits into from
Aug 24, 2015

Conversation

Alkarex
Copy link
Member

@Alkarex Alkarex commented Aug 18, 2015

@Alkarex Alkarex added the I18n 🌍 Translations label Aug 18, 2015
@Alkarex Alkarex added this to the 1.1.3-beta milestone Aug 18, 2015
'de' => 'Deutsch',
'en' => 'English',
'fr' => 'Français',
'nl' => 'Nederlands',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: we should add this line to other files + gen.lang.cz (Čeština) is missing here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done Alkarex@501e331
Maybe in the future we could extract this data, which is the same for all languages.

'submit' => 'Opslaan',
'truncate' => 'Verwijder alle artikelen',
),
'auth' => array(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section does not seem to be the same structure as other languages.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't find anything wrong here.

On 21-8-2015 13:39, Alexandre Alapetite wrote:

In app/i18n/nl/gen.php
#950 (comment):

  •   'create' => 'Opslaan',
    
  •   'disable' => 'Uitzetten',
    
  •   'empty' => 'Leeg',
    
  •   'enable' => 'Aanzetten',
    
  •   'export' => 'Exporteren',
    
  •   'filter' => 'Filteren',
    
  •   'import' => 'Importeren',
    
  •   'manage' => 'Beheren',
    
  •   'mark_read' => 'Markeer als gelezen',
    
  •   'mark_favorite' => 'Markeer als favoriet',
    
  •   'remove' => 'Verwijder',
    
  •   'see_website' => 'Bekijk website',
    
  •   'submit' => 'Opslaan',
    
  •   'truncate' => 'Verwijder alle artikelen',
    
  • ),
  • 'auth' => array(

This section does not seem to be the same structure as other languages.


Reply to this email directly or view it on GitHub
https://github.com/FreshRSS/FreshRSS/pull/950/files#r37626640.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Wanabo
Copy link
Contributor

Wanabo commented Aug 21, 2015

Yes it is Dutch (Nederlands). I'll doublecheck the file with the remark about "This section does not seem to be the same structure as other languages.". But as far as I can tell now it is original only English is translated to Dutch. My site at http://www.nieuwskop.be (version 1.1.2.beta) is working perfectly with it.

By the way, I'm also the translator for the Dutch languages files of the open source CMS PHP-Fusion.

Please keep in mind that I have two versions of Dutch translations available at github.
One for version 1.0.0 and one for version 1.2.2.beta

Suggestion for detecting available languages: Scan app\i18n\ for available languages and match them with a predefined table for full language display.

@Wanabo
Copy link
Contributor

Wanabo commented Aug 21, 2015

Couldn't find anything wrong in gen.php.
Missed a translation in conf.php
'content' => 'Content width',
adjusted to:
'content' => 'Inhoud breedte',

@Alwaysin
Copy link
Contributor

Completely unrelated but @Wanabo, could you share your CSS rules?

I love the density you achieved on your website.

@Alkarex
Copy link
Member Author

Alkarex commented Aug 21, 2015

Missed a translation in conf.php

Done Alkarex@b3ae940

Couldn't find anything wrong in gen.php.

See in auth: password, registration, username, which should be arrays (maybe @marienfressinaud can confirm the intention) :

It is also good to double-check that en/gen.php and nl/gen.php have the same number of lines.

@Wanabo
Copy link
Contributor

Wanabo commented Aug 21, 2015

I've rechecked every file for version 1.1.2 beta.

I updated the files when I saw non translated parts on my website when I updated from version 1.0.0. to 1.1.2 beta. That is not a good strategy! It seems I missed some additions. Now at least all files have the same number of lines and did a file comparison between 'en' and 'nl'.

I've noticed a lot of language definitions return in different files. Isn't it possible to define returning strings in a master language file. That would save work. For example install.php and admin.php share a lot of content.

Or an on board language editor.

@marienfressinaud
Copy link
Member

@Alkarex > you should consider branch 1.1.2 of @Wanabo: https://github.com/Wanabo/FreshRSS-Dutch-translation/tree/1.1.2-beta

@Alkarex
Copy link
Member Author

Alkarex commented Aug 21, 2015

@marienfressinaud Yes, that is the one I took ( https://github.com/Wanabo/FreshRSS-Dutch-translation/blob/c2385d656f598ae8344506e67337bad4e8dd3dac/gen.php ) I can see that there has been some changes today.

@Alkarex
Copy link
Member Author

Alkarex commented Aug 21, 2015

@Wanabo
Copy link
Contributor

Wanabo commented Aug 21, 2015

@Alwaysin It's very simple. I added some modified css from base-theme to dark.css and left base-theme original. You can download Theme DarkDense (inspired on Theme Dark) here, http://www.nieuwskop.be/theme-upload/DarkDense.zip

@Alwaysin
Copy link
Contributor

Thanks for the theme! Works great 👍

Maybe we could add it in FreshRSS by default?

@marienfressinaud
Copy link
Member

@Alkarex > is the PR ready to merge?

@Wanabo and @Alwaysin > note there is an extension to add CSS rules: I think you don't need a specific theme to achieve this ;)

@Alkarex
Copy link
Member Author

Alkarex commented Aug 24, 2015

@marienfressinaud Yes, ready. The PR integrates the latest changes from https://github.com/Wanabo/FreshRSS-Dutch-translation/commits/1.1.2-beta

@Wanabo
Copy link
Contributor

Wanabo commented Aug 24, 2015

Yeah with xExtension-CustomCSS all themes become dense with just a few lines of CSS.

I've setup a small tutorial. Achieve more dense themes with xExtension-CustomCSS

marienfressinaud added a commit that referenced this pull request Aug 24, 2015
@marienfressinaud marienfressinaud merged commit 70544d8 into FreshRSS:dev Aug 24, 2015
@marienfressinaud
Copy link
Member

Merged!

Thank you @Wanabo :)

@Alkarex Alkarex deleted the Dutch branch August 29, 2015 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I18n 🌍 Translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants