This repository has been archived by the owner on Sep 14, 2023. It is now read-only.
Python 3.8+ compatibility and cover support #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks so much for the PR! Everything looks good. Nice that you even added the covers. Would be nice if you could elaborate on the removal of zeroconf. |
|
I took out the mDNS based auto detection because it kept raising errors even after my attempts to fix it; currently the only way to set up the component is manually via host IP. Will check it out again as I still have to add sensors and improve light vs switch detection. Plus some goodies like getting some of the built-in sensors going... |
|
🎉 This PR is included in version 1.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Closed
|
Merged and released. Thanks again! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch to fix issue above + added support for covers
New requirement: Pymee 1.5.4
Important: Zeroconf support removed