-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update develop branch to master #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update const.py - Add AttributeTypes above 324 - Count up Version number - v1.5.5 add attributes - Add more constants - Added constants found in https://github.com/stfnhmplr/homee-api/blob/main/lib/enums.js - revert version number - will be done automatically - revert version 1.5.5. change - will be done automatically.
This changes logging, so it uses a logger with (__name__), so logs can be identified easier. This also will enable log configuration in Home Assistant.
Homee Attributes can have options, that will be exposed with this patch. Options that are not present will have empty values.
* add function to get an update for an attribute * Change get_attribute to update_attribute and add update_node
* add function to get an update for an attribute * Change get_attribute to update_attribute and add update_node * Fix invalid state error * Add manual update functions to readme
* add function to get an update for an attribute * Change get_attribute to update_attribute and add update_node * Fix invalid state error * Add manual update functions to readme * fix list object is not an iterator * unquote homee_name closes #7
* Remove expicit ping Removing the ping-handler function and it's call, since websockets sends pings automatically and the function was causing async_io errors. * Refine error handling and logging Narrrow websocket exception hadnling to "ConnectionClosedError" from "ConnectionClosed" where feasible. some logging changes * expose attribute_map Expose _attribute_map as public property, since it is used in hass-homee * Tackle deprecations and lint warnings - Replace typing.List with list - remove unnecessary else:s - use Callable from collections.abc * refine logging - log disconnect and reconnect once as per https://developers.home-assistant.io/docs/integration_quality_scale_index/ - use %s instead of f-strings in Log-statements as per HA style guide: https://developers.home-assistant.io/docs/development_guidelines/#use-new-style-string-formatting * fix typo * fix some nits - make sure disconnect warning is only logged once. - move logging of reconnect attempts to proper location.
* Remove expicit ping Removing the ping-handler function and it's call, since websockets sends pings automatically and the function was causing async_io errors. * Refine error handling and logging Narrrow websocket exception hadnling to "ConnectionClosedError" from "ConnectionClosed" where feasible. some logging changes * expose attribute_map Expose _attribute_map as public property, since it is used in hass-homee * Tackle deprecations and lint warnings - Replace typing.List with list - remove unnecessary else:s - use Callable from collections.abc * refine logging - log disconnect and reconnect once as per https://developers.home-assistant.io/docs/integration_quality_scale_index/ - use %s instead of f-strings in Log-statements as per HA style guide: https://developers.home-assistant.io/docs/development_guidelines/#use-new-style-string-formatting * fix typo * fix some nits - make sure disconnect warning is only logged once. - move logging of reconnect attempts to proper location. * Deal with attributes without options If trying to access options if the attribute has none leads to an error. This fixes it. * Now really deal with empty options First attempt had a wrong idea.
* Remove expicit ping Removing the ping-handler function and it's call, since websockets sends pings automatically and the function was causing async_io errors. * Refine error handling and logging Narrrow websocket exception hadnling to "ConnectionClosedError" from "ConnectionClosed" where feasible. some logging changes * expose attribute_map Expose _attribute_map as public property, since it is used in hass-homee * Tackle deprecations and lint warnings - Replace typing.List with list - remove unnecessary else:s - use Callable from collections.abc * refine logging - log disconnect and reconnect once as per https://developers.home-assistant.io/docs/integration_quality_scale_index/ - use %s instead of f-strings in Log-statements as per HA style guide: https://developers.home-assistant.io/docs/development_guidelines/#use-new-style-string-formatting * fix typo * fix some nits - make sure disconnect warning is only logged once. - move logging of reconnect attempts to proper location. * Deal with attributes without options If trying to access options if the attribute has none leads to an error. This fixes it. * Now really deal with empty options First attempt had a wrong idea. * Add catch for OS ConnectionError If a connection error throws at OS Level (e.g. 113 - No route to host), it was not caught.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to latest version to test repo rights.