Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cake 4.x Stable #291

Merged
merged 5 commits into from
Dec 18, 2019
Merged

Cake 4.x Stable #291

merged 5 commits into from
Dec 18, 2019

Conversation

kyleweishaupt
Copy link
Contributor

Update CakePHP dependency to 4.0 stable. Closes #290

Require 4.0 stable release
Fix line break causing test to fail
Don't change line ending to be cross OS safe
@dereuromark
Copy link
Member

dereuromark commented Dec 18, 2019

FILE: /home/travis/build/FriendsOfCake/CakePdf/src/Pdf/Engine/MpdfEngine.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 20 | ERROR | [x] The first expression of a multi-line control structure must
    |       |     be on the line after the opening parenthesis

one cs error

  Line   Pdf/CakePdf.php                                                 
 ------ ---------------------------------------------------------------- 
  958    Static method Cake\Routing\Router::getRequest() invoked with 1  
         parameter, 0 required.                                          
 ------ --------

one phpstan error

and all is green.

@dereuromark
Copy link
Member

We will also need to merge master into 4.x later
05aa0bf
then it should be releasable as beta.

Remove router getRequest parameter
Move expression to new line
@dereuromark dereuromark merged commit 2f40aab into FriendsOfCake:cake-4.x Dec 18, 2019
@kyleweishaupt kyleweishaupt deleted the cake-4.x branch December 18, 2019 18:20
@ADmad
Copy link
Member

ADmad commented Dec 18, 2019

If have taken care of fixing errors reported by static analyzers and adding typhints where possible after this merge.

The CakePdf class has many combined getter/setter methods. Is anyone interested in splitting them into separate methods? If not I can do a beta release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants