Fixing undefined offset notice if fields are empty #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you change the tests so that you add a test, not modify the existing ones? |
|
Does that work, or would it be better to make a new fork/pull request to keep commit history clean? |
|
You can squash your commits and then force push to this branch, then I can merge it in :) |
|
Squashed. |
josegonzalez
added a commit
that referenced
this pull request
Jul 17, 2013
Fixing undefined offset notice if fields are empty
|
Merged, thanks for the pull request! |
joshuapaling
added a commit
to joshuapaling/cakephp-csvview
that referenced
this pull request
Jul 23, 2013
Pull request FriendsOfCake#7 has an issue where rows that contain missing / null values will have their columns out of alignment with the data in other columns, and with the header/footer. This resolves that issue by adding a string as a placeholder for null or missing columns. The value of this string can be changed via the $_null configuration option, and defaults to 'NULL'. I think this code should also resolve issue FriendsOfCake#6. Signed-off-by: Joshua Paling <joshua.paling@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
$this->CsvView->quickExport($users);with a table containing empty (not null) fields was giving me a PHP notice:Notice (8): Undefined offset: 0 [APP/Plugin/CsvView/View/CsvView.php, line 214]This seems to fix the notice, and exports work as expected.