Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect to last page if requested page number doesn't exist. #630

Merged
merged 2 commits into from
Oct 17, 2019

Conversation

ADmad
Copy link
Member

@ADmad ADmad commented Oct 16, 2019

FriendsOfCake/crud-view#268 would retain the query string including page number. So if you were on last page with single record, redirecting back to same URL after record is deleted would cause paginator to throw NotFoundException.

@ADmad ADmad changed the title Redirect to first page if requested page number doesn't exist. Redirect to last page if requested page number doesn't exist. Oct 16, 2019
@ADmad ADmad merged commit 1f6bd85 into cake-4.x Oct 17, 2019
@ADmad ADmad deleted the page-out-of-bounds branch October 17, 2019 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant