Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix `fix` command to handle `--fixers` option when contains extra and excluding fixers #599
This PR fixes this behavior, so enable both type filters when mixed filters given.
<?php echo 'foo'.'bar', PHP_EOL;
Current version: (
Fixed version: (
Thanks for your comments! I replied some line notes.
If you will keep this PR with only one commit then please, do it. If PR will has several then I will do it during merge.
Yeah, 5.3, sorry ;)
No problems on that, just now we have one variable with dual responsibility. You are dealing with them now so it will be cool to fix it as well ;) Just create Config::$level for level value and change Config::$fixers to handle only fixers array
I test this branch a lot, results are below.
Result: Take level from config.
Result: Take level from option.
Result: Take level from option and apply fixers from options as patch.
Result: Take level from option and ignore level from config. Then apply fixers from config as patch.
When sb run
This was referenced
Oct 28, 2014
I am not PR-ing with code I don't want to be merged ;)
If you agreed with changes just accept that PR (fivestar#2). I don't change the whole strategy - just fix 2 cases.
The other thing is if this PR (#599) will be merged - and I will be glad to see more opinions here.
Why to remove? The new commits are good - they improve this PR (#599).
Yes, I can perform a merge. But since this PR change tool interface and break BC it is worthly to give community a time to give a feedback with opinion :)