Skip to content

feature: LongToShorthandOperatorFixer - Introduction #6385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

feature: LongToShorthandOperatorFixer - Introduction #6385

wants to merge 1 commit into from

Conversation

SpacePossum
Copy link
Contributor

closes #3515

@coveralls
Copy link

coveralls commented May 13, 2022 •
edited
Loading

Coverage Status

Coverage increased (+0.004%) to 92.92% when pulling 80e127c on SpacePossum:master_shorthand_operator2 into aafad72 on FriendsOfPHP:master.

@SpacePossum
Copy link
Contributor Author

SpacePossum commented May 14, 2022 •
edited
Loading

the SCA reporting seems broken, also locally it yield different results

@SpacePossum SpacePossum force-pushed the master_shorthand_operator2 branch from c8d851b to 10d4c9a Compare June 13, 2022 19:47
@SpacePossum SpacePossum changed the title LongToShorthandOperatorFixer - Introduction feature: LongToShorthandOperatorFixer - Introduction Jun 13, 2022
@SpacePossum SpacePossum force-pushed the master_shorthand_operator2 branch 2 times, most recently from 5e83e38 to 224a7be Compare July 9, 2022 06:32
@SpacePossum
Copy link
Contributor Author

rebased on latest and resolved conflict, no other changes

@SpacePossum SpacePossum force-pushed the master_shorthand_operator2 branch from 224a7be to 9751f4c Compare July 18, 2022 05:48
@SpacePossum
Copy link
Contributor Author

rebased, no other changes

@SpacePossum
Copy link
Contributor Author

fix prio value after rebase

@SpacePossum SpacePossum force-pushed the master_shorthand_operator2 branch from 90383b9 to 11d039c Compare July 25, 2022 04:52
@SpacePossum
Copy link
Contributor Author

rebased on lastest without other changes

@keradus
Copy link
Member

keradus commented Jul 25, 2022

Can you pls check PHPStan errors for this PR?

@SpacePossum SpacePossum force-pushed the master_shorthand_operator2 branch from 5163c04 to 96b55cc Compare July 25, 2022 15:11
@SpacePossum
Copy link
Contributor Author

thanks, all green now

julienfalque
julienfalque reviewed Aug 13, 2022
View reviewed changes
src/Fixer/Operator/AssignNullCoalescingToCoalesceEqualFixer.php
use PhpCsFixer\Tokenizer\Tokens;

final class AssignNullCoalescingToCoalesceEqualFixer extends AbstractFixer
final class AssignNullCoalescingToCoalesceEqualFixer extends AbstractShortOperatorFixer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of using an abstract class, I would suggest deprecating this fixer and moving its logic to LongToShorthandOperatorFixer.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we do this in a follow up PR? It will require making the new LongToShorthandOperatorFixer configurable so it can be used to only behave as the current AssignNullCoalescingToCoalesceEqualFixer.

@SpacePossum SpacePossum force-pushed the master_shorthand_operator2 branch from 96b55cc to a73689f Compare August 21, 2022 14:17
@SpacePossum
Copy link
Contributor Author

rebase on latest without changes

@SpacePossum
Copy link
Contributor Author

Error: Ignored error pattern #^.+no value type specified in iterable type.+.$# in path * is expected to occur 482 times, but occurred 483 times.

This is becoming a bit of a pain, can we not disable the check?

@SpacePossum
Copy link
Contributor Author

and can we run all SCA even if the first tool fails?

@SpacePossum SpacePossum force-pushed the master_shorthand_operator2 branch 2 times, most recently from b1896e5 to 95e0c68 Compare August 31, 2022 09:18
@SpacePossum
Copy link
Contributor Author

rebased on latest, no other changes

@SpacePossum SpacePossum force-pushed the master_shorthand_operator2 branch from 95e0c68 to 831e815 Compare September 5, 2022 09:55
@SpacePossum
Copy link
Contributor Author

rebase on latest without changes

@SpacePossum SpacePossum force-pushed the master_shorthand_operator2 branch from 831e815 to 80e127c Compare September 7, 2022 05:02
@SpacePossum SpacePossum closed this Oct 3, 2022
@SpacePossum SpacePossum deleted the master_shorthand_operator2 branch October 3, 2022 18:38
@Wirone Wirone added the status/to recover PRs that were closed without being merged, but can be refreshed and continued label Jun 13, 2023
@Wirone Wirone mentioned this pull request Sep 12, 2023
Merged
@Wirone Wirone removed the status/to recover PRs that were closed without being merged, but can be refreshed and continued label Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienfalque julienfalque julienfalque left review comments

Assignees
No one assigned
Labels
kind/feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fixer for assignment operators
5 participants
@SpacePossum @coveralls @keradus @julienfalque @Wirone