Skip to content

feature: NoUselessTryCatchFinallyFixer - Introduction #6393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

feature: NoUselessTryCatchFinallyFixer - Introduction #6393

wants to merge 1 commit into from

Conversation

SpacePossum
Copy link
Contributor

@SpacePossum SpacePossum commented May 15, 2022 •
edited
Loading

closes #6158

hits on WordPress, drupal, magento2 and bolt.

@SpacePossum SpacePossum marked this pull request as draft May 15, 2022 09:09
@SpacePossum SpacePossum marked this pull request as ready for review May 15, 2022 09:14
@coveralls
Copy link

coveralls commented May 15, 2022 •
edited
Loading

Coverage Status

Coverage increased (+0.02%) to 92.94% when pulling 69d5100 on SpacePossum:master_NoUselessTryCatchFinallyFixer into aafad72 on FriendsOfPHP:master.

@SpacePossum SpacePossum changed the title NoUselessTryCatchFinallyFixer - Introduction feature: NoUselessTryCatchFinallyFixer - Introduction Jun 13, 2022
@SpacePossum SpacePossum force-pushed the master_NoUselessTryCatchFinallyFixer branch from 34c396a to b42eda7 Compare July 18, 2022 05:49
@SpacePossum
Copy link
Contributor Author

rebased, nothing else

@SpacePossum SpacePossum force-pushed the master_NoUselessTryCatchFinallyFixer branch from b42eda7 to 10d943e Compare July 25, 2022 04:53
@SpacePossum
Copy link
Contributor Author

rebased on latest, only change is conflict resolve of the PHPDoc of the priority method of some rule, no functional change

@SpacePossum SpacePossum force-pushed the master_NoUselessTryCatchFinallyFixer branch from 10d943e to 601400d Compare August 31, 2022 09:18
@SpacePossum
Copy link
Contributor Author

rebase on latest, no other changes

@SpacePossum SpacePossum force-pushed the master_NoUselessTryCatchFinallyFixer branch 3 times, most recently from 7d94e71 to d581d0d Compare September 5, 2022 09:54
@SpacePossum SpacePossum force-pushed the master_NoUselessTryCatchFinallyFixer branch from d581d0d to 69d5100 Compare September 7, 2022 04:49
@SpacePossum SpacePossum closed this Oct 3, 2022
@SpacePossum SpacePossum deleted the master_NoUselessTryCatchFinallyFixer branch October 3, 2022 18:38
@Wirone Wirone added the status/to recover PRs that were closed without being merged, but can be refreshed and continued label Jul 2, 2023
@Wirone Wirone mentioned this pull request Jul 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
kind/feature status/to recover PRs that were closed without being merged, but can be refreshed and continued
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Removal of try-catch blocks which only throw
3 participants
@SpacePossum @coveralls @Wirone