Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Add (almost) all security bulletins for TYPO3 community extensions #126

Closed
wants to merge 3 commits into from
Closed

Conversation

ghost
Copy link

@ghost ghost commented Nov 29, 2015

This commit adds almost (!) all security bulletins for every community extension
of the CMS "TYPO3" hosted on TYPO3's "TYPO3 extension repository" (TER).

About 70 security bulletins are not included in this pull request. As these
bulletins need some more manual work all missing security bulletins will be
pushed in the next days if this commit is accepted.

'php validator.php' notes that all included packages are 'Invalid composer
package'. As far as I can see this is caused by the fact that TER hosted
TYPO3 extensions are not hosted on packagist.org but on TYPO3's own composer
repository at https://composer.typo3.org/. I hope it is possible to use this
security advisories anyway.

Some information about that can be found at composer.typo3.org.

@ghost
Copy link
Author

ghost commented Nov 29, 2015

I am not sure if it is right that I only used branch "master" here.

@ghost
Copy link
Author

ghost commented Nov 29, 2015

'php validator.php' notes that all included packages are 'Invalid composer
package'. As far as I can see this is caused by the fact that TER hosted
TYPO3 extensions are not hosted on packagist.org but on TYPO3's own composer
repository at https://composer.typo3.org/. I hope it is possible to use this
security advisories anyway.

Some information about that can be found at composer.typo3.org.

…nsions hosted on TER"

This commit adds almost every security bulletin for every community extension
of the CMS "TYPO3" hosted on TYPO3's "TYPO3 extension repository" (TER).

About 70 security bulletins are not included in this pull request. As these
bulletins need some more manual work all missing security bulletins will be
pushed in the next days if this commit is accepted.

'php validator.php' notes that all included packages are 'Invalid composer
package'. As far as I can see this is caused by the fact that TER hosted
TYPO3 extensions are not hosted on packagist.org but on TYPO3's own composer
repository at https://composer.typo3.org/. I hope it is possible to use this
security advisories anyway.

Some information about that can be found at composer.typo3.org.
@xabbuh
Copy link
Member

xabbuh commented Nov 30, 2015

@mostwanted1976 looks like that problem is somewhat related to #107 (though here we still have Composer packagist but not hosted on packagist.org)

branches:
master:
time: 2009-12-01 12:00
versions: [<=1.2.0]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we generally write them as <1.2.1 (where 1.2.1 is the release containing the fix)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version number containing the fix is not noted in the of the TYPO3 project's security bulletins. It would be really a lot of work to identify those release numbers. Therefore I would be happy if <= would also do the job.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, it should do it

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

@stof
Copy link
Member

stof commented Nov 30, 2015

@mostwanted1976 see #127 for my proposal about packages on custom composer repositories

kirtixs pushed a commit to kirtixs/security-advisories that referenced this pull request Apr 27, 2016
kirtixs pushed a commit to kirtixs/security-advisories that referenced this pull request Apr 27, 2016
fabpot added a commit that referenced this pull request Feb 1, 2017
This PR was squashed before being merged into the master branch (closes #128).

Discussion
----------

Check any Composer repository

This is an attempt to implement #127 (and would allow #126 to pass). I haven't used the `ComposerRepository` class before, but couldn't see a simple way to consistently find out if a repository knew a particular package name, so it's doing a search then cycling through the results.

Commits
-------

0cfad5a Check any Composer repository
@fabpot
Copy link
Member

fabpot commented Feb 1, 2017

Now that we support external Composer repository, anyone willing to finish this one?

@fabpot fabpot closed this Feb 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants