Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecation for TokenInterface::getRoles #526

Merged
merged 1 commit into from
Jul 5, 2019
Merged

Fix deprecation for TokenInterface::getRoles #526

merged 1 commit into from
Jul 5, 2019

Conversation

jderusse
Copy link
Contributor

@jderusse jderusse commented Jul 3, 2019

Symfony deprecate the method getRole in favor of getRoleNames.

This PR update the RoleProvider to check the current behavior of symfony and use the best method.

Toflar
Toflar approved these changes Jul 3, 2019
View reviewed changes
Copy link
Contributor

@Toflar Toflar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. @dbu failing tests are still related to the docs somehow :/

dbu
dbu approved these changes Jul 5, 2019
View reviewed changes
Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@dbu dbu merged commit f34d771 into FriendsOfSymfony:master Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbu dbu dbu approved these changes

@Toflar Toflar Toflar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jderusse @dbu @Toflar